🐛service logs file not uploaded when service failing (#4242)

ITISFoundation · May 16, 2023 · 2a687cf · 2a687cf
1 parent dab760d
commit 2a687cf
Show file tree

Hide file tree

Showing 10 changed files with 171 additions and 285 deletions.
diff --git a/packages/service-library/src/servicelib/logging_utils.py b/packages/service-library/src/servicelib/logging_utils.py
@@ -256,11 +256,26 @@ def get_log_record_extra(*, user_id: int | str | None = None) -> LogExtra | None
 def guess_message_log_level(message: str) -> LogLevelInt:
     lower_case_message = message.lower().strip()
     if lower_case_message.startswith(
-        ("error:", "err:", "error ", "err ", "[error]", "[err]")
+        (
+            "error",
+            "[error]",
+            "err",
+            "[err]",
+            "exception",
+            "[exception]",
+            "exc:",
+            "exc ",
+            "[exc]",
+        )
     ):
         return logging.ERROR
     if lower_case_message.startswith(
-        ("warning:", "warn:", "warning ", "warn ", "[warning]", "[warn]")
+        (
+            "warning",
+            "[warning]",
+            "warn",
+            "[warn]",
+        )
     ):
         return logging.WARNING
     return logging.INFO
diff --git a/services/dask-sidecar/src/simcore_service_dask_sidecar/computational_sidecar/core.py b/services/dask-sidecar/src/simcore_service_dask_sidecar/computational_sidecar/core.py
@@ -28,7 +28,7 @@
 from settings_library.s3 import S3Settings
 from yarl import URL
 
-from ..dask_utils import TaskPublisher, create_dask_worker_logger, publish_event
+from ..dask_utils import TaskPublisher, publish_event
 from ..file_utils import pull_file_from_remote, push_file_to_remote
 from ..settings import Settings
 from .docker_utils import (
@@ -43,7 +43,7 @@
 from .models import LEGACY_INTEGRATION_VERSION
 from .task_shared_volume import TaskSharedVolumes
 
-logger = create_dask_worker_logger(__name__)
+logger = logging.getLogger(__name__)
 CONTAINER_WAIT_TIME_SECS = 2