Skip to content

Commit

Permalink
unknown tasks are still to be processed as completed.. since they are…
Browse files Browse the repository at this point in the history
… lost and failed
  • Loading branch information
sanderegg committed Dec 20, 2023
1 parent ba8d106 commit b6e9915
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -532,18 +532,16 @@ async def _update_states_from_comp_backend(
run_metadata=pipeline_params.run_metadata,
)

if sorted_tasks.completed:
if sorted_tasks.completed or sorted_tasks.potentially_lost:
await self._process_completed_tasks(
user_id,
sorted_tasks.completed,
sorted_tasks.completed + sorted_tasks.potentially_lost,
iteration,
pipeline_params=pipeline_params,
)

if sorted_tasks.waiting or sorted_tasks.potentially_lost:
await self._process_waiting_tasks(
sorted_tasks.waiting + sorted_tasks.potentially_lost
)
if sorted_tasks.waiting:
await self._process_waiting_tasks(sorted_tasks.waiting)

@abstractmethod
async def _start_tasks(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ async def _process_completed_tasks(
async def _process_task_result(
self,
task: CompTaskAtDB,
result: Exception | TaskOutputData,
result: BaseException | TaskOutputData,
run_metadata: RunMetadataDict,
iteration: Iteration,
) -> None:
Expand Down

0 comments on commit b6e9915

Please sign in to comment.