Skip to content

Commit

Permalink
fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
sanderegg committed Aug 8, 2023
1 parent fb9256e commit c15ba73
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 13 deletions.
6 changes: 5 additions & 1 deletion services/director-v2/tests/unit/with_dbs/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,11 @@ async def running_project(
dag_adjacency_list=fake_workbench_adjacency,
),
tasks=tasks(
user=user, project=created_project, state=StateType.RUNNING, progress=0.0
user=user,
project=created_project,
state=StateType.RUNNING,
progress=0.0,
start=datetime.datetime.now(tz=datetime.timezone.utc),
),
runs=runs(user=user, project=created_project, result=StateType.RUNNING),
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
InstrumentationRabbitMessage,
RabbitResourceTrackingHeartbeatMessage,
RabbitResourceTrackingMessages,
RabbitResourceTrackingStartedMessage,
RabbitResourceTrackingStoppedMessage,
_RabbitResourceTrackingBaseMessage,
)
Expand Down Expand Up @@ -625,8 +626,8 @@ def _parser(x) -> RabbitResourceTrackingMessages:

messages = await _assert_message_received(
resource_tracking_rabbit_client_parser,
2,
_parser,
1,
RabbitResourceTrackingStartedMessage.parse_raw,
)
assert messages[0].node_id == exp_started_task.node_id

Expand Down Expand Up @@ -753,8 +754,8 @@ async def _return_2nd_task_running(job_ids: list[str]) -> list[RunningState]:
assert messages[0].service_uuid == exp_started_task.node_id
messages = await _assert_message_received(
resource_tracking_rabbit_client_parser,
2,
_parser,
1,
RabbitResourceTrackingStartedMessage.parse_raw,
)
assert messages[0].node_id == exp_started_task.node_id

Expand Down Expand Up @@ -843,6 +844,8 @@ async def _return_3rd_task_success(job_ids: list[str]) -> list[RunningState]:
2,
_parser,
)
assert isinstance(messages[0], RabbitResourceTrackingStartedMessage)
assert isinstance(messages[1], RabbitResourceTrackingStoppedMessage)

# the scheduled pipeline shall be removed
assert scheduler.scheduled_pipelines == {}
Expand Down Expand Up @@ -1169,16 +1172,12 @@ async def _return_1st_task_running(job_ids: list[str]) -> list[RunningState]:
mocked_dask_client.get_tasks_status.side_effect = _return_1st_task_running
await run_comp_scheduler(scheduler)

def _parser(x) -> RabbitResourceTrackingMessages:
return parse_raw_as(RabbitResourceTrackingMessages, x)

messages = await _assert_message_received(
resource_tracking_rabbit_client_parser,
2,
_parser,
1,
RabbitResourceTrackingStartedMessage.parse_raw,
)
assert messages[0].node_id == exp_started_task.node_id
assert isinstance(messages[1], RabbitResourceTrackingHeartbeatMessage)

# -------------------------------------------------------------------------------
# 3. wait a bit and run again we should get another heartbeat, but only one!
Expand All @@ -1188,7 +1187,7 @@ def _parser(x) -> RabbitResourceTrackingMessages:
messages = await _assert_message_received(
resource_tracking_rabbit_client_parser,
1,
_parser,
RabbitResourceTrackingHeartbeatMessage.parse_raw,
)
assert isinstance(messages[0], RabbitResourceTrackingHeartbeatMessage)

Expand All @@ -1200,6 +1199,6 @@ def _parser(x) -> RabbitResourceTrackingMessages:
messages = await _assert_message_received(
resource_tracking_rabbit_client_parser,
1,
_parser,
RabbitResourceTrackingHeartbeatMessage.parse_raw,
)
assert isinstance(messages[0], RabbitResourceTrackingHeartbeatMessage)

0 comments on commit c15ba73

Please sign in to comment.