Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of storage service #1588

Closed
pcrespov opened this issue Jun 29, 2020 · 2 comments
Closed

Refactoring of storage service #1588

pcrespov opened this issue Jun 29, 2020 · 2 comments
Assignees
Labels
a:storage issue related to storage service t:enhancement Improvement or request on an existing feature

Comments

@pcrespov
Copy link
Member

After the upgrade of this service, many improvements seem necesary in order to achieve a maintainable service.

Most of the small issues are just marked as TODO: or FIXME: directly in the code and the most relevant are:

  • install blackfynn agent and use it in the code. For the moment, this feature is disabled (look for us_agent=False flag).
  • refactor blackfynn wrappers layers dsm -> datcore_wrapper -> dat_core. There is a lot of room for improvement there to make it more maintainable and not so verbose.
  • do not use protected api in blackfynn library e.g. bf._api.io.upload
  • Prefer None to "" (empty strings) in returns when something
  • add annotations
@pcrespov pcrespov added a:storage issue related to storage service t:enhancement Improvement or request on an existing feature labels Jun 29, 2020
@GitHK GitHK assigned pcrespov and sanderegg and unassigned GitHK Aug 6, 2021
@GitHK
Copy link
Contributor

GitHK commented Aug 6, 2021

Both of you should know more about the state of this issue.

@pcrespov
Copy link
Member Author

Outdated and replaced by backlog at #2396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:storage issue related to storage service t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants