-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring storage: removed s3wrapper #2295
Refactoring storage: removed s3wrapper #2295
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2295 +/- ##
========================================
- Coverage 71.8% 71.8% -0.1%
========================================
Files 504 505 +1
Lines 19702 19856 +154
Branches 1931 1948 +17
========================================
+ Hits 14161 14260 +99
- Misses 5069 5120 +51
- Partials 472 476 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e39eae6
to
08c3b0d
Compare
08c3b0d
to
54907b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always good to remove stuff!
packages/pytest-simcore/src/pytest_simcore/monkeypatch_extra.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One less dependency to handle, nice!
What do these changes do?
REMOVES
module because :packages/s3wrapper
storage
service,Highlights
simcore_service_storage.s3wrapper
)pytest_simcore.minio_services
to avoid dependency with s3wrapperpytest_simcore.monkeypatch_extra
to enhance testingsimcore_sdk/requirements/_test.in
NOTE: constraint
minio<7
due to breaking API changes -> needs review of entire python client.Related issue/s
This is a part of PR #1588 separated in a single PR to simplify review.
How to test
Most tests in repo affected
Checklist