-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP ♻️ storage tests refactoring #2276
Closed
pcrespov
wants to merge
38
commits into
ITISFoundation:master
from
pcrespov:maintenance/storage-api-refactor
Closed
WIP ♻️ storage tests refactoring #2276
pcrespov
wants to merge
38
commits into
ITISFoundation:master
from
pcrespov:maintenance/storage-api-refactor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df8b919
to
20731fa
Compare
Codecov Report
@@ Coverage Diff @@
## master #2276 +/- ##
========================================
- Coverage 74.8% 68.9% -5.9%
========================================
Files 560 537 -23
Lines 20868 19408 -1460
Branches 2018 1871 -147
========================================
- Hits 15621 13389 -2232
- Misses 4719 5626 +907
+ Partials 528 393 -135
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4867e95
to
0fcd5b7
Compare
This was referenced Apr 28, 2021
c848ffe
to
ecce45a
Compare
ecce45a
to
2f42373
Compare
3 tasks
2f42373
to
b25c596
Compare
b25c596
to
1f877f6
Compare
1f877f6
to
2c982ca
Compare
2c982ca
to
7751b7a
Compare
5 tasks
7751b7a
to
2bfd349
Compare
5 tasks
f5da824
to
4df09f6
Compare
2f245cb
to
363de02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Upgrades storage service folder structure
s3wrapper
( separate PR Refactoring storage: removed s3wrapper #2295 )storage_sdk
? ? -> Only used innode-ports
. Basically node-ports is an sdk on top of storage and the pg db. The latter should be avoided.urllib3
constraint due to aioboto!Related issue/s
How to test
cd services/storage make install-dev make info make test-dev
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)