Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP ♻️ storage tests refactoring #2276

Closed

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Apr 14, 2021

What do these changes do?

Upgrades storage service folder structure

  • updates test folder
  • updates tests fixtures
  • update reqs: see requires.io
  • deprecate s3wrapper ( separate PR Refactoring storage: removed s3wrapper #2295 )
  • upgrades service dependencies
  • disables blackfynn and removes dependencies
  • deprecate storage_sdk? ? -> Only used in node-ports. Basically node-ports is an sdk on top of storage and the pg db. The latter should be avoided.
  • resolve urllib3 constraint due to aioboto!
  • remove attrs

Related issue/s

How to test

cd services/storage
make install-dev
make info
make test-dev

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@pcrespov pcrespov self-assigned this Apr 14, 2021
@pcrespov pcrespov changed the title WIP [skip ci] WIP maintenance: storage api refactoring Apr 14, 2021
@pcrespov pcrespov changed the title WIP maintenance: storage api refactoring WIP 🏗️ maintenance: storage api refactoring Apr 14, 2021
@pcrespov pcrespov added a:api framework api, data schemas, a:storage issue related to storage service labels Apr 14, 2021
@pcrespov pcrespov added this to the Schwarznasenschaf milestone Apr 14, 2021
@pcrespov pcrespov force-pushed the maintenance/storage-api-refactor branch from df8b919 to 20731fa Compare April 22, 2021 21:33
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #2276 (363de02) into master (1c816d3) will decrease coverage by 5.8%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2276     +/-   ##
========================================
- Coverage    74.8%   68.9%   -5.9%     
========================================
  Files         560     537     -23     
  Lines       20868   19408   -1460     
  Branches     2018    1871    -147     
========================================
- Hits        15621   13389   -2232     
- Misses       4719    5626    +907     
+ Partials      528     393    -135     
Flag Coverage Δ
integrationtests ?
unittests 68.9% <ø> (-0.4%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/simcore-sdk/src/simcore_sdk/models/base.py 0.0% <0.0%> (-100.0%) ⬇️
...ges/simcore-sdk/src/simcore_sdk/models/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
...es/sidecar/src/simcore_service_sidecar/mpi_lock.py 29.6% <0.0%> (-70.4%) ⬇️
...core-sdk/src/simcore_sdk/models/pipeline_models.py 0.0% <0.0%> (-64.6%) ⬇️
...imcore_service_webserver/exporter/export_import.py 34.1% <0.0%> (-61.0%) ⬇️
...re-sdk/src/simcore_sdk/node_ports/serialization.py 24.6% <0.0%> (-57.0%) ⬇️
...c/simcore_service_director_v2/utils/async_utils.py 32.7% <0.0%> (-56.9%) ⬇️
...vice_webserver/exporter/formatters/formatter_v2.py 31.9% <0.0%> (-56.4%) ⬇️
..._director_v2/modules/db/repositories/comp_tasks.py 40.0% <0.0%> (-56.0%) ⬇️
...ore_service_director_v2/api/routes/computations.py 35.9% <0.0%> (-55.3%) ⬇️
... and 76 more

@pcrespov pcrespov force-pushed the maintenance/storage-api-refactor branch 5 times, most recently from 4867e95 to 0fcd5b7 Compare April 27, 2021 18:38
@pcrespov pcrespov force-pushed the maintenance/storage-api-refactor branch from c848ffe to ecce45a Compare May 3, 2021 06:10
@pcrespov pcrespov force-pushed the maintenance/storage-api-refactor branch from ecce45a to 2f42373 Compare May 10, 2021 19:23
@pcrespov pcrespov mentioned this pull request May 10, 2021
3 tasks
@pcrespov pcrespov force-pushed the maintenance/storage-api-refactor branch from 2f42373 to b25c596 Compare May 11, 2021 15:42
@pcrespov pcrespov force-pushed the maintenance/storage-api-refactor branch from b25c596 to 1f877f6 Compare May 18, 2021 23:03
@pcrespov pcrespov force-pushed the maintenance/storage-api-refactor branch from 1f877f6 to 2c982ca Compare May 26, 2021 07:21
@pcrespov pcrespov changed the title WIP 🏗️ maintenance: storage api refactoring WIP 🏗️ maintenance: storage refactoring backlog May 26, 2021
@pcrespov pcrespov force-pushed the maintenance/storage-api-refactor branch from 2c982ca to 7751b7a Compare June 3, 2021 09:30
@pcrespov pcrespov force-pushed the maintenance/storage-api-refactor branch from 7751b7a to 2bfd349 Compare June 9, 2021 13:41
@pcrespov pcrespov force-pushed the maintenance/storage-api-refactor branch 2 times, most recently from f5da824 to 4df09f6 Compare June 21, 2021 21:02
@pcrespov pcrespov force-pushed the maintenance/storage-api-refactor branch from 2f245cb to 363de02 Compare July 6, 2021 16:10
@pcrespov pcrespov changed the title WIP 🔨 storage tests refactoring WIP ♻️ storage tests refactoring Jul 6, 2021
@pcrespov pcrespov modified the milestones: Chinchilla, Chevrotain Aug 20, 2021
@pcrespov pcrespov removed this from the Chevrotain milestone Sep 21, 2021
@pcrespov pcrespov added this to the Rudolph milestone Jan 15, 2022
@pcrespov pcrespov modified the milestones: Rudolph, Rudolph+1 Feb 4, 2022
@pcrespov pcrespov removed this from the R.Schumann milestone Mar 14, 2022
@pcrespov pcrespov added this to the E.Shackleton milestone Mar 24, 2022
@pcrespov pcrespov modified the milestones: E.Shackleton, a-mile-stone Apr 9, 2022
@pcrespov pcrespov closed this May 25, 2022
@pcrespov pcrespov deleted the maintenance/storage-api-refactor branch May 25, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:api framework api, data schemas, a:storage issue related to storage service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant