Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiP - Activity Manager #1099

Closed
wants to merge 123 commits into from
Closed

Conversation

ignapas
Copy link
Contributor

@ignapas ignapas commented Oct 9, 2019

What do these changes do?

Introduces a working prototype for the activity manager, displaying CPU and memory usage for every container running a dynamic service and the base for the api definition.

Related issue number

#525 #1034

How to test

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Runs in the swarm
  • If you design a new module, add your user to .github/CODEOWNERS

odeimaiz and others added 30 commits July 4, 2019 18:48
Added documentation to ServiceFilters
Added study filter to activity monitor
Added study filter to activity monitor.
 Conflicts:
	services/web/client/source/class/osparc/auth/Manager.js
	services/web/client/source/class/osparc/auth/ui/LoginView.js
	services/web/client/source/class/osparc/component/filter/TagsFilter.js
	services/web/client/source/class/osparc/component/form/renderer/PropForm.js
	services/web/client/source/class/osparc/component/metadata/StudyDetailsEditor.js
	services/web/client/source/class/osparc/component/widget/InputsMapper.js
	services/web/client/source/class/osparc/component/widget/inputs/NodeOutputListIcon.js
	services/web/client/source/class/osparc/component/widget/inputs/NodeOutputTree.js
	services/web/client/source/class/osparc/component/workbench/NodeUI.js
	services/web/client/source/class/osparc/component/workbench/WorkbenchUI.js
	services/web/client/source/class/osparc/data/Permissions.js
	services/web/client/source/class/osparc/data/model/Node.js
	services/web/client/source/class/osparc/desktop/ServiceFilters.js
	services/web/client/source/class/osparc/desktop/StudyBrowser.js
	services/web/client/source/class/osparc/desktop/StudyEditor.js
	services/web/client/source/class/osparc/desktop/preferences/pages/SecurityPage.js
	services/web/client/source/class/osparc/file/FilesTree.js
	services/web/client/source/class/osparc/io/WatchDog.js
	services/web/client/source/class/osparc/io/rest/ResourceFactory.js
	services/web/client/source/class/osparc/statics/NodeStatics.js
	services/web/client/source/class/osparc/store/Data.js
	services/web/client/source/class/osparc/store/Store.js
	services/web/client/source/class/osparc/utils/Services.js
 Conflicts:
	services/web/client/source/class/osparc/component/service/manager/ActivityManager.js
	services/web/client/source/class/osparc/component/service/manager/ActivityTree.js
	services/web/client/source/class/osparc/desktop/NavigationBar.js
Added memory calculations.
In activity manager, now showing running containers, without the use of harcoded metadata.
@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #1099 into master will decrease coverage by 7.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1099     +/-   ##
=========================================
- Coverage   69.63%   62.53%   -7.1%     
=========================================
  Files         140       30    -110     
  Lines        6197     1767   -4430     
=========================================
- Hits         4315     1105   -3210     
+ Misses       1882      662   -1220
Impacted Files Coverage Δ
.../server/src/simcore_service_webserver/login/sql.py
.../server/src/simcore_service_webserver/s3_config.py
...r/src/simcore_service_webserver/computation_api.py
.../server/src/simcore_service_webserver/db_models.py
...r/rest/generated_code/models/inline_response200.py
...rc/simcore_service_director/rest/node_validator.py
...t/generated_code/models/inline_response201_data.py
...ver/src/simcore_service_webserver/rest_handlers.py
...ce_director/rest/generated_code/models/__init__.py
.../director/src/simcore_service_director/__main__.py
... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 104bff8...8792b76. Read the comment docs.

Created a new generic extendable osparc table with some convenience methods.
Eslint happy now.
@ignapas ignapas closed this Oct 10, 2019
@ignapas
Copy link
Contributor Author

ignapas commented Oct 10, 2019

Closed as this is just prototype work that won't be merged into master. It will be used for a demo and as base for future work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants