-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗️ Maintenance week 48: requirements tooling refactor and library upgrades #2005
Merged
pcrespov
merged 10 commits into
ITISFoundation:master
from
pcrespov:maintenance-week-48
Nov 30, 2020
Merged
🏗️ Maintenance week 48: requirements tooling refactor and library upgrades #2005
pcrespov
merged 10 commits into
ITISFoundation:master
from
pcrespov:maintenance-week-48
Nov 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2005 +/- ##
========================================
- Coverage 73.7% 67.9% -5.9%
========================================
Files 390 390
Lines 14344 14344
Branches 1441 1441
========================================
- Hits 10580 9745 -835
- Misses 3379 4255 +876
+ Partials 385 344 -41
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b2ba717
to
4192b62
Compare
…okie_jar fails to return auth cookie with aiohttp==3.7.X. Needs further investigation
470e443
to
b52a244
Compare
GitHK
approved these changes
Nov 30, 2020
sanderegg
approved these changes
Nov 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice cleanup!! just 1,2 questions
pcrespov
added a commit
to pcrespov/osparc-simcore
that referenced
this pull request
Mar 9, 2022
pcrespov
added a commit
to pcrespov/osparc-simcore
that referenced
this pull request
Mar 17, 2022
pcrespov
added a commit
to pcrespov/osparc-simcore
that referenced
this pull request
Mar 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a:infra+ops
maintenance of infrastructure or operations (discussed in retro)
t:maintenance
Some planned maintenance work
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
library upgrades
refactors requirements tooling
Consolidates repo-wide tools, commons and doc under
osparc-simcore/requirements
:requirements/constraints.txt
conditions repo-widescripts/requirements.Makefile
->requirements/base.Makefile
scripts/requirements/*
->requirements/tools/*
requirements
pytest-simcore
requirementsStarts requirement listings of common tooling and libraries for testing. Added under
packages/pytest-simcore/requirements
. The idea is to install them viapytest-simcore
package using suitable combinations using the extras_require option of the setup. This PR is just a preparation and will be implemented in the next maintenance PR.