Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗️ Maintenance week 48: requirements tooling refactor and library upgrades #2005

Merged
merged 10 commits into from
Nov 30, 2020

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 26, 2020

What do these changes do?

library upgrades

refactors requirements tooling

Consolidates repo-wide tools, commons and doc under osparc-simcore/requirements:

  • common requirements/constraints.txt conditions repo-wide
  • moved scripts/requirements.Makefile -> requirements/base.Makefile
  • moved scripts/requirements/* -> requirements/tools/*
  • moves doc to requirements

pytest-simcore requirements

Starts requirement listings of common tooling and libraries for testing. Added under packages/pytest-simcore/requirements. The idea is to install them via pytest-simcore package using suitable combinations using the extras_require option of the setup. This PR is just a preparation and will be implemented in the next maintenance PR.

@pcrespov pcrespov self-assigned this Nov 26, 2020
@pcrespov pcrespov changed the title WIP: Maintenance week 48 WIP: 🏗️ Maintenance week 48 Nov 26, 2020
@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #2005 (470e443) into master (2834fd9) will decrease coverage by 5.8%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2005     +/-   ##
========================================
- Coverage    73.7%   67.9%   -5.9%     
========================================
  Files         390     390             
  Lines       14344   14344             
  Branches     1441    1441             
========================================
- Hits        10580    9745    -835     
- Misses       3379    4255    +876     
+ Partials      385     344     -41     
Flag Coverage Δ
integrationtests 63.2% <ø> (-0.1%) ⬇️
unittests 63.3% <ø> (-4.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...er/src/simcore_service_webserver/storage_routes.py 20.0% <0.0%> (-80.0%) ⬇️
...er/src/simcore_service_webserver/studies_access.py 24.2% <0.0%> (-64.5%) ⬇️
...er/src/simcore_service_webserver/login/handlers.py 27.9% <0.0%> (-59.9%) ⬇️
...es/sidecar/src/simcore_service_sidecar/executor.py 23.5% <0.0%> (-56.2%) ⬇️
...mcore_service_webserver/login/api_keys_handlers.py 36.7% <0.0%> (-55.9%) ⬇️
...eb/server/src/simcore_service_webserver/statics.py 39.3% <0.0%> (-49.2%) ⬇️
...vice_webserver/studies_dispatcher/handlers_rest.py 52.0% <0.0%> (-48.0%) ⬇️
...rc/simcore_service_webserver/login/confirmation.py 33.3% <0.0%> (-47.3%) ⬇️
...rvices/sidecar/src/simcore_service_sidecar/core.py 24.7% <0.0%> (-46.7%) ⬇️
...rc/simcore_service_webserver/login/registration.py 30.1% <0.0%> (-43.4%) ⬇️
... and 38 more

@pcrespov pcrespov force-pushed the maintenance-week-48 branch from 470e443 to b52a244 Compare November 30, 2020 14:17
@pcrespov pcrespov added a:infra+ops maintenance of infrastructure or operations (discussed in retro) dependencies t:maintenance Some planned maintenance work labels Nov 30, 2020
@pcrespov pcrespov added this to the Alfred_BĂĽchi milestone Nov 30, 2020
@pcrespov pcrespov marked this pull request as ready for review November 30, 2020 14:32
@pcrespov pcrespov changed the title WIP: 🏗️ Maintenance week 48 🏗️ Maintenance week 48: requirements tooling refactor and library upgrades Nov 30, 2020
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup!! just 1,2 questions

@pcrespov pcrespov merged commit 42c5b20 into ITISFoundation:master Nov 30, 2020
@pcrespov pcrespov deleted the maintenance-week-48 branch November 30, 2020 15:10
pcrespov added a commit to pcrespov/osparc-simcore that referenced this pull request Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro) t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants