Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: errors middleware captures CancelledError in handlers #2215

Closed

Conversation

pcrespov
Copy link
Member

What do these changes do?

Related issue/s

Zero downtime: Connected users should be able to continue working with osparc when osparc micro-services are restarted #2212

How to test

Checklist

@pcrespov pcrespov self-assigned this Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #2215 (8943673) into master (ab717cb) will decrease coverage by 0.0%.
The diff coverage is 44.4%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2215     +/-   ##
========================================
- Coverage    73.2%   73.2%   -0.1%     
========================================
  Files         465     465             
  Lines       17939   17946      +7     
  Branches     1766    1767      +1     
========================================
+ Hits        13145   13147      +2     
- Misses       4341    4346      +5     
  Partials      453     453             
Flag Coverage Δ
integrationtests 65.5% <ø> (-0.1%) ⬇️
unittests 66.7% <44.4%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...service-library/src/servicelib/rest_middlewares.py 61.7% <44.4%> (-2.5%) ⬇️
...webserver/computation_comp_tasks_listening_task.py 88.1% <0.0%> (-3.3%) ⬇️
...erver/src/simcore_service_webserver/director_v2.py 87.2% <0.0%> (-0.9%) ⬇️
...simcore_service_webserver/projects/projects_api.py 88.4% <0.0%> (-0.6%) ⬇️
.../director/src/simcore_service_director/producer.py 60.4% <0.0%> (-0.3%) ⬇️
...ce_webserver/resource_manager/garbage_collector.py 77.6% <0.0%> (+2.7%) ⬆️

@pcrespov
Copy link
Member Author

discarded

@pcrespov pcrespov closed this Apr 19, 2021
@pcrespov pcrespov deleted the is2212/webserver-shutdown branch April 30, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant