Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactoring web-server settings and removing trafaret from the repo #2376

Closed

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 9, 2021

What do these changes do?

Related issue/s

How to test

Checklist

@pcrespov pcrespov self-assigned this Jun 9, 2021
@pcrespov pcrespov added this to the Chinchilla milestone Jun 9, 2021
@pcrespov pcrespov added a:services-library issues on packages/service-libs a:webserver issue related to the webserver service t:enhancement Improvement or request on an existing feature labels Jun 9, 2021
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #2376 (80246ed) into master (32f6501) will decrease coverage by 10.9%.
The diff coverage is 83.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2376      +/-   ##
=========================================
- Coverage    74.2%   63.3%   -11.0%     
=========================================
  Files         518     351     -167     
  Lines       20320   12411    -7909     
  Branches     2012    1246     -766     
=========================================
- Hits        15093    7865    -7228     
+ Misses       4708    4288     -420     
+ Partials      519     258     -261     
Flag Coverage Δ
integrationtests ?
unittests 63.3% <83.3%> (-4.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/service-library/src/servicelib/tracing.py 0.0% <0.0%> (ø)
packages/simcore-sdk/src/simcore_sdk/settings.py 100.0% <ø> (ø)
...core-sdk/src/simcore_sdk/node_ports/filemanager.py 45.7% <100.0%> (-33.8%) ⬇️
...es/storage/src/simcore_service_storage/settings.py 100.0% <100.0%> (ø)
...ackages/simcore-sdk/src/simcore_sdk/models/base.py 0.0% <0.0%> (-100.0%) ⬇️
...ges/simcore-sdk/src/simcore_sdk/models/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
...es/sidecar/src/simcore_service_sidecar/mpi_lock.py 29.6% <0.0%> (-70.4%) ⬇️
...core-sdk/src/simcore_sdk/models/pipeline_models.py 0.0% <0.0%> (-64.6%) ⬇️
...re-sdk/src/simcore_sdk/node_ports/serialization.py 24.6% <0.0%> (-57.0%) ⬇️
...c/simcore_service_director_v2/utils/async_utils.py 32.7% <0.0%> (-56.9%) ⬇️
... and 200 more

@pcrespov pcrespov force-pushed the refactor/webserver-settings branch from 1968218 to 80246ed Compare June 21, 2021 11:04
@pcrespov pcrespov changed the title 🔨 Refactoring web-server settings and removing trafaret from the repo ♻️ Refactoring web-server settings and removing trafaret from the repo Jul 6, 2021
@pcrespov pcrespov modified the milestones: Chinchilla, Chevrotain Aug 20, 2021
@pcrespov pcrespov modified the milestones: Chevrotain, Capra delle nevi Sep 21, 2021
@pcrespov pcrespov mentioned this pull request Dec 17, 2021
5 tasks
@pcrespov
Copy link
Member Author

pcrespov commented Jan 5, 2022

Split into PRs #2716 and #2719

@pcrespov pcrespov closed this Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:services-library issues on packages/service-libs a:webserver issue related to the webserver service t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant