🔨 Adding monitor to director-v2 #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
June 30, 2021 13:40
Codecov Report
@@ Coverage Diff @@
## master #2411 +/- ##
========================================
+ Coverage 75.5% 76.0% +0.5%
========================================
Files 558 571 +13
Lines 20780 21498 +718
Branches 2010 2066 +56
========================================
+ Hits 15691 16356 +665
- Misses 4562 4592 +30
- Partials 527 550 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
added 2 commits
June 30, 2021 16:31
added 11 commits
June 30, 2021 16:54
added 12 commits
July 7, 2021 16:56
pcrespov
reviewed
Jul 8, 2021
services/director-v2/tests/unit/test_modules_dynamic_sidecar_monitor.py
Outdated
Show resolved
Hide resolved
pcrespov
approved these changes
Jul 8, 2021
sanderegg
approved these changes
Jul 8, 2021
...ces/director-v2/src/simcore_service_director_v2/models/schemas/dynamic_services/scheduler.py
Show resolved
Hide resolved
| return cls(**params) | ||
|
|
||
| class Config: | ||
| extra = Extra.allow |
There was a problem hiding this comment.
Because it is inheriting from DynamicSidecarServiceLabels which is configured as Extra.forid and is not able to merge extra arguments coming from other models via inheritance and additional properties.
services/director-v2/src/simcore_service_director_v2/models/schemas/dynamic_services/service.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/docker_states.py
Show resolved
Hide resolved
pcrespov
added a commit
that referenced
this pull request
Jul 14, 2021
Settings introduced in PR #2411 fail to initialize when deployed in master environment * Disables dynamic sidecar settings * Fixes dynamic-services vs dynamic-sidecar settings * Adds test with envdevel * disables scheduler in client fixture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Brings in the monitor, a component used by the director-v2 to keep track of the status of the dynamic-sidecars and trigger events in reaction to status changes. Changes coming from #1887
Related issue/s
How to test
Checklist