-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Maintenance/add consistency scripts #2531
✨ Maintenance/add consistency scripts #2531
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2531 +/- ##
========================================
- Coverage 76.5% 76.5% -0.1%
========================================
Files 610 610
Lines 23397 23397
Branches 2294 2294
========================================
- Hits 17917 17909 -8
- Misses 4873 4880 +7
- Partials 607 608 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Super nice and useful scripts! A few suggestion:
|
b5c67e9
to
1bb8f3a
Compare
getting files from s3 ongoing
1bb8f3a
to
5ac74cf
Compare
|
||
def write_file(file_path: Path, data, fieldnames): | ||
with file_path.open("w", newline="") as csvfile: | ||
csv_writer = csv.writer(csvfile) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nce touch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
real nice
What do these changes do?
The scripts does the following:
pre-requisite:
make import-db-from-docker-volume
in /packages/postgres-database)Related issue/s
How to test
Checklist