-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Maintenance/week 38 dependencies #2545
Merged
pcrespov
merged 30 commits into
ITISFoundation:master
from
pcrespov:maintenance/week38-dependencies
Sep 20, 2021
Merged
⬆️ Maintenance/week 38 dependencies #2545
pcrespov
merged 30 commits into
ITISFoundation:master
from
pcrespov:maintenance/week38-dependencies
Sep 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2545 +/- ##
========================================
- Coverage 76.9% 71.4% -5.5%
========================================
Files 619 619
Lines 23958 23968 +10
Branches 2345 2345
========================================
- Hits 18429 17133 -1296
- Misses 4905 6289 +1384
+ Partials 624 546 -78
Flags with carried forward coverage won't be shown. Click here to find out more.
|
GitHK
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up
sanderegg
approved these changes
Sep 20, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
🐛 FIX: After PR ♻️ Maintenance/refactors servicelib #2516,
servicelib
dependencies were reduced by adding a separate[aiohttp]
extra requirements option. Sinceservicelib
is also (wrongly) added as a dependency bysimcore-sdk
, then several services requirements were not updated, namelypublic-api
,sidecar
,dask-sidecar
andtests/swarm
⬆️ Full repo upgrades
consider-using-in
,no-self-use
, ...celery
which constraintsclick<8.0,>=7.0
uvicorn
which constraintsclick 7.1.2
Updates docs, Makefile
In order to avoid too much clutter, we will upgrade second-order test/tooling libraries in a separate PR
Related issue/s
How to test
All tests involved