Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Study Editor redesign #2571

Merged
merged 90 commits into from
Oct 21, 2021
Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 5, 2021

What do these changes do?

1st iteration (functionalities only) in the Study Editor redesign:

  • Nodes tree with icons and at the same level. Study node is shown with the home icon.
    • Action buttons: On the right of the node items, action buttons are shown if the mouse is hovering. Interactive services show also a full screen button.
  • Integrated file system viewer shares space with nodes tree.
  • Integrated input/settings and output controls in secondary column for dynamic, computational and parameters.
  • Information view in secondary column for study and files.
  • Integrated workbench, node iframe and logger

StSudyEditor
StSudyEditor2

  • Update e2e tests

Related issue/s

related to ITISFoundation/osparc-issues#546

How to test

Checklist

@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Oct 5, 2021
@odeimaiz odeimaiz added this to the Capra delle nevi milestone Oct 5, 2021
@odeimaiz odeimaiz self-assigned this Oct 5, 2021
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #2571 (69f1653) into master (ee99322) will decrease coverage by 2.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2571      +/-   ##
=========================================
- Coverage    71.8%   69.7%    -2.2%     
=========================================
  Files         618     105     -513     
  Lines       23910    2636   -21274     
  Branches     2356     212    -2144     
=========================================
- Hits        17181    1838   -15343     
+ Misses       6174     760    -5414     
+ Partials      555      38     -517     
Flag Coverage Δ
unittests 69.7% <ø> (-2.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/sidecar/src/simcore_service_sidecar/boot_mode.py
...ages/settings-library/src/settings_library/base.py
...ice-library/src/servicelib/aiohttp/rest_routing.py
...src/simcore_service_director_v2/api/routes/meta.py
.../src/simcore_service_sidecar/task_shared_volume.py
...mcore_service_webserver/login/api_keys_handlers.py
...service_webserver/version_control_handlers_base.py
...rc/simcore_service_webserver/login/confirmation.py
...src/simcore_service_api_server/api/routes/files.py
...ce_webserver/resource_manager/garbage_collector.py
... and 503 more

@odeimaiz odeimaiz removed this from the Capra delle nevi milestone Oct 6, 2021
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hot

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very pretty!

@odeimaiz odeimaiz added this to the Anti-PER milestone Oct 21, 2021
@sanderegg sanderegg merged commit 71579eb into ITISFoundation:master Oct 21, 2021
@odeimaiz odeimaiz deleted the feature/stsudy-editor branch April 21, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants