Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX empty File Picker #2648

Merged
merged 37 commits into from
Nov 23, 2021
Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 17, 2021

What do these changes do?

This PR improves the UX when the File Picker has no file selected. When the empty File Picker is selected a "Drop here" field is shown and the Files Tree tab is shown in the primary column.
In the "Drop here" field, files coming from the Files Tree and also the ones coming from the user's local storage can be Drag&Dropped.

EmptyFP

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Nov 17, 2021
@odeimaiz odeimaiz added this to the Meerkat milestone Nov 17, 2021
@odeimaiz odeimaiz self-assigned this Nov 17, 2021
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #2648 (37fb76c) into master (01106aa) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2648   +/-   ##
======================================
  Coverage    78.1%   78.1%           
======================================
  Files         635     635           
  Lines       25918   25918           
  Branches     2507    2507           
======================================
+ Hits        20248   20261   +13     
+ Misses       5008    4998   -10     
+ Partials      662     659    -3     
Flag Coverage Δ
integrationtests 67.0% <ø> (+<0.1%) ⬆️
unittests 73.6% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...webserver/computation_comp_tasks_listening_task.py 80.2% <0.0%> (-3.2%) ⬇️
..._director_v2/modules/dynamic_sidecar/docker_api.py 87.2% <0.0%> (+0.5%) ⬆️
...simcore_service_webserver/projects/projects_api.py 83.8% <0.0%> (+1.0%) ⬆️
.../src/simcore_service_webserver/director_v2_core.py 69.5% <0.0%> (+1.1%) ⬆️
...car/src/simcore_service_dask_sidecar/dask_utils.py 90.4% <0.0%> (+1.1%) ⬆️
...rc/simcore_service_director_v2/modules/rabbitmq.py 89.4% <0.0%> (+1.7%) ⬆️
...ce_webserver/resource_manager/garbage_collector.py 78.8% <0.0%> (+2.0%) ⬆️
...ce_webserver/resource_manager/websocket_manager.py 97.3% <0.0%> (+4.0%) ⬆️

@odeimaiz odeimaiz marked this pull request as ready for review November 22, 2021 09:04
@odeimaiz odeimaiz changed the title WIP: UI/UX empty File Picker UI/UX empty File Picker Nov 22, 2021
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is very nice!
just wondering why the node in the workbench changes shape only when a file is selected. should it have always the same shape?

Copy link
Contributor

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just to clarify - when there is a file picked for the File Picker, would the user ever be able to change the file? It looks like the file metadata is shown for a file picker node after one is picked so to change files, the user would need to delete that file picker and create another one. I'm not sure this is ideal but I will let you judge on that.

@odeimaiz
Copy link
Member Author

Very nice! Just to clarify - when there is a file picked for the File Picker, would the user ever be able to change the file? It looks like the file metadata is shown for a file picker node after one is picked so to change files, the user would need to delete that file picker and create another one. I'm not sure this is ideal but I will let you judge on that.

Correct. I thought there was no need to add a "Clear selection" button since it usually never changes, but I might be wrong....

@KZzizzle
Copy link
Contributor

Very nice! Just to clarify - when there is a file picked for the File Picker, would the user ever be able to change the file? It looks like the file metadata is shown for a file picker node after one is picked so to change files, the user would need to delete that file picker and create another one. I'm not sure this is ideal but I will let you judge on that.

Correct. I thought there was no need to add a "Clear selection" button since it usually never changes, but I might be wrong....

Personally I like being able to change the file "in place" so I don't have to reconnect/map inputs. One example is if I'm troubleshooting a python runner or something. Perhaps @newton1985 has an opinion?

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful! 🎉
just a minor suggestion on the message: Drop file/s here instead of simpley Drop Here

@odeimaiz odeimaiz merged commit 0b3eb3a into ITISFoundation:master Nov 23, 2021
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Dec 6, 2021
@odeimaiz odeimaiz deleted the feature/ux-empty-fp branch April 21, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants