-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/UX empty File Picker #2648
UI/UX empty File Picker #2648
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2648 +/- ##
======================================
Coverage 78.1% 78.1%
======================================
Files 635 635
Lines 25918 25918
Branches 2507 2507
======================================
+ Hits 20248 20261 +13
+ Misses 5008 4998 -10
+ Partials 662 659 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is very nice!
just wondering why the node in the workbench changes shape only when a file is selected. should it have always the same shape?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just to clarify - when there is a file picked for the File Picker, would the user ever be able to change the file? It looks like the file metadata is shown for a file picker node after one is picked so to change files, the user would need to delete that file picker and create another one. I'm not sure this is ideal but I will let you judge on that.
Correct. I thought there was no need to add a "Clear selection" button since it usually never changes, but I might be wrong.... |
Personally I like being able to change the file "in place" so I don't have to reconnect/map inputs. One example is if I'm troubleshooting a python runner or something. Perhaps @newton1985 has an opinion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beautiful! 🎉
just a minor suggestion on the message: Drop file/s here
instead of simpley Drop Here
What do these changes do?
This PR improves the UX when the File Picker has no file selected. When the empty File Picker is selected a "Drop here" field is shown and the Files Tree tab is shown in the primary column.
In the "Drop here" field, files coming from the Files Tree and also the ones coming from the user's local storage can be Drag&Dropped.
Related issue/s
How to test
Checklist