-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Maintenance/new settings (1st round) #2736
♻️ Maintenance/new settings (1st round) #2736
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2736 +/- ##
======================================
Coverage 78.2% 78.2%
======================================
Files 647 652 +5
Lines 26915 26963 +48
Branches 2617 2617
======================================
+ Hits 21062 21106 +44
- Misses 5144 5146 +2
- Partials 709 711 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
35da085
to
4219ad3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! please have a look at my comments before merging
@@ -2,7 +2,7 @@ | |||
from pydantic.tools import parse_raw_as | |||
from settings_library.base import BaseCustomSettings | |||
|
|||
from .constants import GB | |||
from ._constants import GB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is there a _ in front of the module name? it cannot be re-used outside of the library? stuff like GB
is not really something private is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a way to say to express what is part of the API of the library and what is not
the constants, as you mention, are not too troublesome regarding coupling BUT this way I avoid having the services importing the same constant from different libraries. That is the ida
packages/settings-library/src/settings_library/utils_service.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/meta_modeling_handlers.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/projects_exceptions.py
Outdated
Show resolved
Hide resolved
4219ad3
to
7d39f3e
Compare
What do these changes do?
This is the first of a series of PR that will progressively introduce the new-settings (i.e. move from
trafaret
tosettings_library
) in the entire repo. In this PR we address:✨
settings_library
:base
prefixutils_
prefix_constants
♻️
webserver
settings
->application_settings
since it goes side-by-side withapplication_*
modulesconstants
->_constants
: to stress it is internalNOTE: this PR is very "noisy" but in reality there are very few changes: see commits message to guide your review.
Related issue/s
How to test
webserver and settingslib tests covers changes
Checklist