-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iframe lazy loading #2790
Merged
odeimaiz
merged 6 commits into
ITISFoundation:master
from
odeimaiz:feature/lazy-dy-connect
Feb 4, 2022
Merged
Iframe lazy loading #2790
odeimaiz
merged 6 commits into
ITISFoundation:master
from
odeimaiz:feature/lazy-dy-connect
Feb 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2790 +/- ##
========================================
- Coverage 78.9% 78.8% -0.1%
========================================
Files 670 670
Lines 27186 27186
Branches 2669 2669
========================================
- Hits 21459 21448 -11
- Misses 4971 4981 +10
- Partials 756 757 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sanderegg
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beyond greatness
mrnicegyu11
approved these changes
Feb 4, 2022
super cool, thanks for the notice! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR makes the frontend nodes connect to their dynamic service's iframes on demand.
When opening studies with many dynamic services, all the iframes were connected and opened right away, creating hundreds of parallel requests, overloading the backend and the frontend. With these changes, dynamic services will be started, the
/retrieve
endpoint called, BUT the iframe will not be loaded until the user opens it.Before:

After:

Related issue/s
related to #2785
How to test
Checklist