Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Cluster credentials passed as ***** #2937

Conversation

sanderegg
Copy link
Member

What do these changes do?

creating a cluster or pinging it would use very nice password stars instead of the real password...

Related issue/s

How to test

Checklist

@sanderegg sanderegg added this to the E.Shackleton milestone Apr 1, 2022
@sanderegg sanderegg self-assigned this Apr 1, 2022
@sanderegg sanderegg requested review from pcrespov and GitHK as code owners April 1, 2022 09:20
@sanderegg sanderegg force-pushed the bugfix/secret_str_not_correctly_saved branch from 23f15bd to b43e819 Compare April 1, 2022 09:22
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you are passing the cluster credentials not masked. right?

@sanderegg
Copy link
Member Author

I see you are passing the cluster credentials not masked. right?

@GitHK yesthat is right. the same as the webclient passes them to the webserver actually. Probably also the same as the login information?

@sanderegg sanderegg requested a review from odeimaiz April 1, 2022 09:27
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #2937 (b43e819) into master (3a47716) will increase coverage by 1.3%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2937     +/-   ##
========================================
+ Coverage    78.1%   79.5%   +1.3%     
========================================
  Files         677     677             
  Lines       28231   28238      +7     
  Branches     3643    3643             
========================================
+ Hits        22074   22469    +395     
+ Misses       5367    5004    -363     
+ Partials      790     765     -25     
Flag Coverage Δ
integrationtests 65.6% <33.3%> (-0.1%) ⬇️
unittests 75.1% <100.0%> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...simcore_service_director_v2/api/routes/clusters.py 98.7% <100.0%> (+41.7%) ⬆️
.../src/simcore_service_webserver/director_v2_core.py 74.7% <100.0%> (+0.2%) ⬆️
...rvice-library/src/servicelib/common_aiopg_utils.py 88.2% <0.0%> (-8.9%) ⬇️
.../director/src/simcore_service_director/producer.py 62.1% <0.0%> (+0.4%) ⬆️
...imcore_service_webserver/garbage_collector_core.py 70.0% <0.0%> (+0.9%) ⬆️
...rector_v2/modules/comp_scheduler/dask_scheduler.py 89.6% <0.0%> (+2.0%) ⬆️
...simcore_service_director_v2/modules/director_v0.py 77.4% <0.0%> (+2.1%) ⬆️
.../simcore_service_catalog/services/access_rights.py 81.2% <0.0%> (+2.5%) ⬆️
...e_service_director_v2/models/domains/comp_tasks.py 100.0% <0.0%> (+2.7%) ⬆️
...2/src/simcore_service_director_v2/core/settings.py 98.5% <0.0%> (+2.8%) ⬆️
... and 32 more

settings=settings,
user_id=user_id,
cluster_id=DEFAULT_CLUSTER_ID,
clusters_repo=clusters_repo,
dask_clients_pool=dask_clients_pool,
)
logger.debug("found followind %s", f"{default_cluster=!r}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

followind is like la bise in Lac Leman ?? :-D

@sanderegg sanderegg requested a review from Surfict April 1, 2022 09:49
@sanderegg sanderegg merged commit 12a721a into ITISFoundation:master Apr 1, 2022
@sanderegg sanderegg deleted the bugfix/secret_str_not_correctly_saved branch April 1, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants