-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Cluster credentials passed as ***** #2937
🐛 Cluster credentials passed as ***** #2937
Conversation
23f15bd
to
b43e819
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you are passing the cluster credentials not masked. right?
@GitHK yesthat is right. the same as the webclient passes them to the webserver actually. Probably also the same as the login information? |
Codecov Report
@@ Coverage Diff @@
## master #2937 +/- ##
========================================
+ Coverage 78.1% 79.5% +1.3%
========================================
Files 677 677
Lines 28231 28238 +7
Branches 3643 3643
========================================
+ Hits 22074 22469 +395
+ Misses 5367 5004 -363
+ Partials 790 765 -25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
settings=settings, | ||
user_id=user_id, | ||
cluster_id=DEFAULT_CLUSTER_ID, | ||
clusters_repo=clusters_repo, | ||
dask_clients_pool=dask_clients_pool, | ||
) | ||
logger.debug("found followind %s", f"{default_cluster=!r}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
followind is like la bise
in Lac Leman ?? :-D
What do these changes do?
creating a cluster or pinging it would use very nice password stars instead of the real password...
Related issue/s
How to test
Checklist