Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Annotations #2946

Merged
merged 8 commits into from
Apr 5, 2022
Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 4, 2022

Bugs found during RM:

  • Redraw annotations after reloadModel
  • Initialize annotations property to empty object

Bonus

  • Don't save study if it doesn't change.
  • Nodes Tree: Copy nodeId when clicking on on the nodeId

Related issues

closes #2947
closes #2957

@odeimaiz odeimaiz self-assigned this Apr 4, 2022
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Apr 4, 2022
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #2946 (9917743) into master (8420b65) will increase coverage by 1.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2946     +/-   ##
========================================
+ Coverage    78.3%   79.5%   +1.2%     
========================================
  Files         677     677             
  Lines       28244   28244             
  Branches     3644    3644             
========================================
+ Hits        22133   22479    +346     
+ Misses       5357    5001    -356     
- Partials      754     764     +10     
Flag Coverage Δ
integrationtests 65.7% <ø> (+4.0%) ⬆️
unittests 75.1% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/simcore_service_catalog/core/background_tasks.py 68.4% <0.0%> (-1.1%) ⬇️
.../director/src/simcore_service_director/producer.py 62.1% <0.0%> (+0.4%) ⬆️
...imcore_service_webserver/garbage_collector_core.py 71.0% <0.0%> (+1.8%) ⬆️
...service_director_v2/api/routes/dynamic_services.py 88.2% <0.0%> (+2.1%) ⬆️
.../simcore_service_catalog/services/access_rights.py 81.2% <0.0%> (+2.5%) ⬆️
.../simcore_service_catalog/db/repositories/groups.py 72.9% <0.0%> (+2.7%) ⬆️
...or_v2/models/schemas/dynamic_services/scheduler.py 97.0% <0.0%> (+2.9%) ⬆️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 81.9% <0.0%> (+3.2%) ⬆️
...rc/simcore_service_director_v2/core/application.py 91.6% <0.0%> (+3.3%) ⬆️
...simcore_service_webserver/projects/project_lock.py 100.0% <0.0%> (+5.2%) ⬆️
... and 12 more

@odeimaiz odeimaiz marked this pull request as ready for review April 4, 2022 14:23
@sanderegg sanderegg added this to the a-mile-stone milestone Apr 4, 2022
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean a part of #2957 ??

@odeimaiz odeimaiz merged commit 2c36423 into ITISFoundation:master Apr 5, 2022
@odeimaiz odeimaiz deleted the fix/annotations branch April 5, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
4 participants