Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Maintenance: upgrade to python 3.9.12 #2973

Merged
merged 13 commits into from
Apr 11, 2022

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Apr 8, 2022

What do these changes do?

This upgrades the whole repository to the latest python 3.9.12 version (thus making it fully compatible with ARM/ARMv64 versions in piwheels.org)

In order to upgrade once the PR goes in:

make clean-all
pyenv update
pyenv install 3.9.12
pyenv local 3.9.12
make devenv
source .venv/bin/activate
make build build-devel

some new features:

  • dict unions
  • type hinting using dict, list
  • string method to remove prefixes and suffixes

full reference

Related issue/s

How to test

Checklist

@sanderegg sanderegg added this to the a-mile-stone milestone Apr 8, 2022
@sanderegg sanderegg self-assigned this Apr 8, 2022
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #2973 (cbf3ad6) into master (cd7d039) will decrease coverage by 4.4%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2973     +/-   ##
========================================
- Coverage    79.6%   75.2%   -4.5%     
========================================
  Files         683     683             
  Lines       28504   28504             
  Branches     3671    3671             
========================================
- Hits        22709   21448   -1261     
- Misses       5030    6317   +1287     
+ Partials      765     739     -26     
Flag Coverage Δ
integrationtests ?
unittests 75.2% <100.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rvice-library/src/servicelib/aiohttp/monitoring.py 0.0% <ø> (ø)
...ibrary/src/servicelib/aiohttp/application_setup.py 79.1% <100.0%> (ø)
...simcore_service_webserver/computation_subscribe.py 27.0% <0.0%> (-65.0%) ⬇️
...imcore_service_webserver/exporter/export_import.py 35.7% <0.0%> (-59.6%) ⬇️
...re-sdk/src/simcore_sdk/node_ports/serialization.py 25.0% <0.0%> (-57.4%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 36.8% <0.0%> (-57.0%) ⬇️
...vice_webserver/exporter/formatters/formatter_v2.py 31.9% <0.0%> (-56.4%) ⬇️
...vice_webserver/exporter/formatters/formatter_v1.py 25.0% <0.0%> (-53.9%) ⬇️
...c/simcore_service_webserver/users_to_groups_api.py 46.1% <0.0%> (-53.9%) ⬇️
...ore_service_webserver/exporter/request_handlers.py 38.8% <0.0%> (-52.8%) ⬇️
... and 87 more

@sanderegg sanderegg force-pushed the enhancement/python3_9 branch 2 times, most recently from 7e09498 to 23955e6 Compare April 8, 2022 15:37
@sanderegg sanderegg marked this pull request as ready for review April 8, 2022 15:37
Copy link
Contributor

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the notice!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 great to see how smoothly we transition this time! :-)

@sanderegg sanderegg force-pushed the enhancement/python3_9 branch from 23955e6 to 934d727 Compare April 8, 2022 16:45
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am truly amazed by this! 🎉
Was expecting way more changes!

@sanderegg sanderegg force-pushed the enhancement/python3_9 branch from d473f19 to cbf3ad6 Compare April 11, 2022 06:43
@sanderegg sanderegg merged commit f120326 into ITISFoundation:master Apr 11, 2022
@sanderegg sanderegg deleted the enhancement/python3_9 branch April 11, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants