🚑️ tuning down scheduler for dynamic sidecars

[GitHK]

What do these changes do?

• The dynamic-sidecar scheduler was a bit aggressive and would end up scheduling too many retry attempts. Tuned down the value
• director-v2 will now start dynamic-sidecars with log leve set to WARNING, for development DEBUG will still be set
• Fixed an issue when starting the dynamic-sidecar spawned container. After the first failed attempt, all attempts would add more networks to the network list inside the container service spec.

Related issue/s

How to test

Checklist

[codecov]

Codecov Report

Merging #3025 (651e292) into master (66ea86c) will increase coverage by 13.2%.
The diff coverage is 75.0%.

@@            Coverage Diff            @@
##           master   #3025      +/-   ##
=========================================
+ Coverage    66.5%   79.7%   +13.2%     
=========================================
  Files         572     698     +126     
  Lines       22425   29221    +6796     
  Branches     2905    3756     +851     
=========================================
+ Hits        14917   23297    +8380     
+ Misses       6999    5086    -1913     
- Partials      509     838     +329     

Flag	Coverage Δ
integrationtests	65.9% <72.7%> (?)
unittests	75.4% <66.6%> (+8.9%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...or_v2/models/schemas/dynamic_services/scheduler.py	98.6% <ø> (ø)
...es/dynamic_sidecar/docker_service_specs/sidecar.py	79.0% <ø> (ø)
...ector_v2/modules/dynamic_sidecar/scheduler/task.py	81.9% <50.0%> (ø)
...2/src/simcore_service_director_v2/core/settings.py	96.1% <75.0%> (ø)
...v2/modules/dynamic_sidecar/docker_compose_specs.py	100.0% <100.0%> (ø)
...c/simcore_service_dynamic_sidecar/core/settings.py	96.0% <100.0%> (ø)
...rvice-library/src/servicelib/common_aiopg_utils.py	88.2% <0.0%> (-8.9%)	⬇️
...service_director_v2/api/routes/dynamic_services.py	88.2% <0.0%> (ø)
...ices/storage/src/simcore_service_storage/models.py	78.8% <0.0%> (ø)
..._director_v2/modules/dynamic_sidecar/_constants.py	100.0% <0.0%> (ø)
... and 239 more

[sanderegg]

question, can't it just be a set instead of a list?

[GitHK]

No, it has to be a list inside the yaml that docker-compose up receives.

[sanderegg]

👍

[mrnicegyu11]

thanks!

[pcrespov]

MINOR: ..._LOG_LEVEL: Literal["DEBUG", "WARNING", "INFO", "ERROR"] = ...

[GitHK]

Apparently the literal is not working. Something about inheritance, it cannot be subclassed. As an alternative I've added a validator.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.5% Duplication