-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixes FileLink validation legacy format #3114
🐛 Fixes FileLink validation legacy format #3114
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3114 +/- ##
========================================
+ Coverage 79.6% 81.0% +1.4%
========================================
Files 706 706
Lines 30451 30457 +6
Branches 3944 3945 +1
========================================
+ Hits 24245 24677 +432
+ Misses 5332 4936 -396
+ Partials 874 844 -30
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ee41e1f
to
9c68406
Compare
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good one. Thanks a lot!
What do these changes do?
isolve-gpu e2e test failed (see incident) because
comp_task
tables included some outputs with an old FileLink format.This PR adds a validator in FileLink that handles that legacy format.
A question remains, though: which service is still adding
store="0"
to thecomp_task
??How to test