-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Regression fix: computational services always restarting #3176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3176 +/- ##
======================================
Coverage 81.7% 81.8%
======================================
Files 723 723
Lines 30970 30981 +11
Branches 4005 4009 +4
======================================
+ Hits 25331 25353 +22
+ Misses 4819 4810 -9
+ Partials 820 818 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
odeimaiz
approved these changes
Jul 8, 2022
pcrespov
approved these changes
Jul 8, 2022
pcrespov
reviewed
Jul 8, 2022
pcrespov
reviewed
Jul 8, 2022
services/web/server/src/simcore_service_webserver/projects/projects_db.py
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes regression.
added test to prevent this to happen again.
currently no test for the origin of the problem: #3058
Related issue/s
closes #3137
How to test
Checklist