Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Regression fix: computational services always restarting #3176

Merged
merged 11 commits into from
Jul 8, 2022

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jul 8, 2022

What do these changes do?

Fixes regression.
added test to prevent this to happen again.

currently no test for the origin of the problem: #3058

Related issue/s

closes #3137

How to test

Checklist

@sanderegg sanderegg added this to the Meteora milestone Jul 8, 2022
@sanderegg sanderegg self-assigned this Jul 8, 2022
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #3176 (b066f19) into master (f6060af) will increase coverage by 0.0%.
The diff coverage is 96.5%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3176   +/-   ##
======================================
  Coverage    81.7%   81.8%           
======================================
  Files         723     723           
  Lines       30970   30981   +11     
  Branches     4005    4009    +4     
======================================
+ Hits        25331   25353   +22     
+ Misses       4819    4810    -9     
+ Partials      820     818    -2     
Flag Coverage Δ
integrationtests 66.2% <75.0%> (+<0.1%) ⬆️
unittests 78.3% <75.8%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../service-library/src/servicelib/archiving_utils.py 61.3% <0.0%> (ø)
...mcore_service_webserver/projects/projects_utils.py 84.1% <ø> (ø)
...simcore_service_webserver/projects/projects_api.py 91.1% <100.0%> (ø)
.../simcore_service_webserver/projects/projects_db.py 92.7% <100.0%> (+0.2%) ⬆️
...rvice-library/src/servicelib/common_aiopg_utils.py 88.2% <0.0%> (-8.9%) ⬇️
...ore_service_director_v2/utils/dask_client_utils.py 82.6% <0.0%> (-0.9%) ⬇️
.../director/src/simcore_service_director/producer.py 62.1% <0.0%> (+0.4%) ⬆️
...simcore_service_director_v2/modules/dask_client.py 92.8% <0.0%> (+0.5%) ⬆️
...c/simcore_service_catalog/core/background_tasks.py 67.3% <0.0%> (+1.0%) ⬆️
...e_service_director_v2/modules/dask_clients_pool.py 94.2% <0.0%> (+1.4%) ⬆️
... and 4 more

@sanderegg sanderegg marked this pull request as ready for review July 8, 2022 13:14
@sanderegg sanderegg requested review from pcrespov and GitHK as code owners July 8, 2022 13:14
@sanderegg sanderegg requested review from mrnicegyu11 and odeimaiz July 8, 2022 13:14
@sanderegg sanderegg requested a review from mguidon as a code owner July 8, 2022 14:21
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit e739aaa into ITISFoundation:master Jul 8, 2022
@sanderegg sanderegg deleted the bugfix/3137 branch July 25, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

computational services are always restarting
3 participants