🐛Bugfix: Director v2 called from GC errors because of wrong use of yarl library

[mrnicegyu11]

What do these changes do?

Fixes #3206

How to test

Check that the error and assoc. stack-trace mentioned in the issue #3206 is not happening anymore

Checklist

• Unit tests for the changes exist

[codecov]

Codecov Report

Merging #3207 (045001c) into master (f90a680) will increase coverage by 0.0%.
The diff coverage is 80.0%.

❗ Current head 045001c differs from pull request most recent head 16d5f22. Consider uploading reports for the commit 16d5f22 to get more accurate results

@@          Coverage Diff           @@
##           master   #3207   +/-   ##
======================================
  Coverage    82.0%   82.0%           
======================================
  Files         740     740           
  Lines       31574   31578    +4     
  Branches     4082    4084    +2     
======================================
+ Hits        25897   25906    +9     
+ Misses       4845    4839    -6     
- Partials      832     833    +1     

Flag	Coverage Δ
integrationtests	66.4% <20.0%> (+<0.1%)	⬆️
unittests	78.5% <80.0%> (+<0.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ice_webserver/director_v2_core_dynamic_services.py	65.7% <80.0%> (+3.2%)	⬆️
...rvice_datcore_adapter/utils/requests_decorators.py	68.4% <0.0%> (-10.6%)	⬇️
...mcore_service_webserver/garbage_collector_utils.py	82.0% <0.0%> (-2.6%)	⬇️
...c/simcore_service_catalog/core/background_tasks.py	66.3% <0.0%> (-1.1%)	⬇️
.../director/src/simcore_service_director/producer.py	61.6% <0.0%> (-0.3%)	⬇️
...ce_webserver/resource_manager/websocket_manager.py	94.8% <0.0%> (+1.2%)	⬆️
...imcore_service_webserver/garbage_collector_task.py	100.0% <0.0%> (+2.3%)	⬆️
...imcore_service_webserver/garbage_collector_core.py	68.6% <0.0%> (+2.4%)	⬆️
.../simcore_service_catalog/services/access_rights.py	81.2% <0.0%> (+2.5%)	⬆️
... and 1 more

[GitHK]

Suggested change

	if params != {}: # Update query doesnt work with no params to unwrap
	if not params: # Update query doesnt work with no params to unwrap

[pcrespov]

@GitHK suggestion is good idea BUT the condition he wrote is reversed i.e. it should be

backend_url: URL = settings.base_url / "dynamic_services"
if params:
   backend_url = backend_url.update_query(**params)

[GitHK]

Please addressed the below minor suggestions.

[pcrespov]

BTW i have been looking at the doc and this solution would also work (NOTE no **)

backend_url = (settings.base_url / "dynamic_services").update_query(params)

example

>>> from yarl import URL
>>> URL('http://example.com/path?a=b').update_query({'c': 'd'})
URL('http://example.com/path?a=b&c=d')
>>> URL('http://example.com/path?a=b').update_query({})
URL('http://example.com/path?a=b')
>>> URL('http://example.com/path?a=b').update_query(None)
URL('http://example.com/path?a=b')

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication