Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ maintenance/updates pennsieve library #3246

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Aug 11, 2022

What do these changes do?

  • Updates to latest pennsieve. This update unblocks the upgrade of rsa
  • Remaining changes in requirement files suggest that changes in servicelib requirements were not propagated downstream. It will be corrected in a separate PR

Highlights on updated libraries (only updated libraries are included)

  • #packages before: 2
  • #packages after : 5
# name before after upgrade count packages
1 pennsieve 6.1.2 6.2.0 minor 1 datcore-adapter⬆️
2 rsa 4.0 4.9 minor 1 datcore-adapter⬆️

Legend:

  • ⬆️ base dependency (only services because packages are floating)
  • 🧪 test dependency
  • 🔧 tool dependency

Related issue/s

@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Aug 11, 2022
@pcrespov pcrespov added this to the Brutalism milestone Aug 11, 2022
@pcrespov pcrespov self-assigned this Aug 11, 2022
@pcrespov pcrespov marked this pull request as ready for review August 11, 2022 09:03
@pcrespov pcrespov requested review from GitHK and sanderegg August 11, 2022 09:04
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #3246 (b3e2482) into master (bd9919f) will increase coverage by 1.0%.
The diff coverage is n/a.

❗ Current head b3e2482 differs from pull request most recent head d5d5c81. Consider uploading reports for the commit d5d5c81 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3246     +/-   ##
========================================
+ Coverage    77.5%   78.5%   +1.0%     
========================================
  Files         606     653     +47     
  Lines       24522   26891   +2369     
  Branches     3177    3446    +269     
========================================
+ Hits        19012   21120   +2108     
- Misses       4926    5119    +193     
- Partials      584     652     +68     
Flag Coverage Δ
unittests 78.5% <0.0%> (+1.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../simcore_service_catalog/services/access_rights.py 81.2% <0.0%> (-3.8%) ⬇️
...imcore_service_webserver/garbage_collector_core.py 66.2% <0.0%> (-3.1%) ⬇️
...c/simcore_service_catalog/core/background_tasks.py 66.3% <0.0%> (-2.2%) ⬇️
...car/src/simcore_service_dask_sidecar/dask_utils.py 91.2% <0.0%> (ø)
...es/storage/src/simcore_service_storage/s3_utils.py 85.0% <0.0%> (ø)
...dask_sidecar/computational_sidecar/docker_utils.py 87.0% <0.0%> (ø)
services/storage/src/simcore_service_storage/db.py 83.3% <0.0%> (ø)
...vices/storage/src/simcore_service_storage/_meta.py 100.0% <0.0%> (ø)
...es/storage/src/simcore_service_storage/__main__.py 0.0% <0.0%> (ø)
...s/storage/src/simcore_service_storage/s3_client.py 98.2% <0.0%> (ø)
... and 44 more

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooh great!

@pcrespov pcrespov force-pushed the maintenance/upgrades-datacore-adapter branch from a87f94b to d5d5c81 Compare August 11, 2022 16:29
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit fba9e70 into ITISFoundation:master Aug 11, 2022
@pcrespov pcrespov deleted the maintenance/upgrades-datacore-adapter branch August 11, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants