Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ webserver: fixes mypy issues in socketio plugin #3774

Merged
merged 19 commits into from
May 11, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jan 18, 2023

What do these changes do?

This PR refactors socketio as a pre-requisite to #2410

  • ♻️ webserver's socketio plugin
    • plugin folder split in protected/public sub-modules
    • messages api module to communicate with the front-end image
    • socketio + observer event handlers
    • fixes mypy issues

Related issue/s

How to test

cd service/web/server
make install-dev
make mypy | grep socketio

@pcrespov pcrespov marked this pull request as draft January 18, 2023 11:42
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #3774 (9556126) into master (7bf1f6f) will decrease coverage by 7.2%.
The diff coverage is 91.6%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3774     +/-   ##
========================================
- Coverage    85.5%   78.4%   -7.2%     
========================================
  Files         954     798    -156     
  Lines       41416   35680   -5736     
  Branches      953     545    -408     
========================================
- Hits        35439   27994   -7445     
- Misses       5760    7569   +1809     
+ Partials      217     117    -100     
Flag Coverage Δ
integrationtests 79.5% <ø> (+11.0%) ⬆️
unittests 77.9% <91.6%> (-4.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...service-library/src/servicelib/aiohttp/observer.py 83.8% <83.8%> (ø)
...rc/simcore_service_webserver/socketio/_handlers.py 84.9% <84.9%> (ø)
...erver/src/simcore_service_webserver/login/utils.py 96.2% <100.0%> (ø)
...ice_webserver/notifications/_rabbitmq_consumers.py 34.2% <100.0%> (-61.5%) ⬇️
...rc/simcore_service_webserver/projects/_observer.py 100.0% <100.0%> (ø)
...r/src/simcore_service_webserver/projects/plugin.py 100.0% <100.0%> (ø)
...simcore_service_webserver/projects/projects_api.py 81.3% <100.0%> (-12.3%) ⬇️
...rc/simcore_service_webserver/socketio/_observer.py 100.0% <100.0%> (ø)
...r/src/simcore_service_webserver/socketio/_utils.py 97.5% <100.0%> (ø)
...src/simcore_service_webserver/socketio/messages.py 95.0% <100.0%> (ø)
... and 2 more

... and 303 files with indirect coverage changes

GitHK

This comment was marked as off-topic.

@pcrespov pcrespov self-assigned this Jan 18, 2023
@pcrespov pcrespov force-pushed the is2410/maintenance-logout branch 2 times, most recently from b8f03eb to b78027e Compare January 19, 2023 18:23
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@pcrespov pcrespov force-pushed the is2410/maintenance-logout branch from b78027e to 9c1c816 Compare February 6, 2023 18:30
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov added this to the Resistance Is Futile milestone Feb 6, 2023
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Apr 12, 2023
@pcrespov pcrespov modified the milestones: Jelly Beans, Pastel de Nata May 5, 2023
@pcrespov pcrespov force-pushed the is2410/maintenance-logout branch 2 times, most recently from 6cffab4 to cbcc154 Compare May 10, 2023 18:44
@pcrespov pcrespov changed the title WIP: ✨ Is2410/maintenance logout ♻️ webserver: fixes mypy issues in socketio plugin May 10, 2023
@pcrespov pcrespov force-pushed the is2410/maintenance-logout branch from c54deec to a886f02 Compare May 11, 2023 09:32
@pcrespov pcrespov marked this pull request as ready for review May 11, 2023 10:29
@pcrespov pcrespov requested review from GitHK and sanderegg May 11, 2023 10:29
@pcrespov pcrespov force-pushed the is2410/maintenance-logout branch 2 times, most recently from a43467c to 48aed32 Compare May 11, 2023 17:02
@pcrespov pcrespov force-pushed the is2410/maintenance-logout branch from 48aed32 to 9556126 Compare May 11, 2023 18:08
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented May 11, 2023

Code Climate has analyzed commit 9556126 and detected 0 issues on this pull request.

View more on Code Climate.

@pcrespov pcrespov enabled auto-merge (squash) May 11, 2023 18:10
@pcrespov pcrespov merged commit afb9b0e into ITISFoundation:master May 11, 2023
@pcrespov pcrespov deleted the is2410/maintenance-logout branch May 12, 2023 16:58
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants