-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ webserver
: fixes mypy issues in socketio
plugin
#3774
♻️ webserver
: fixes mypy issues in socketio
plugin
#3774
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3774 +/- ##
========================================
- Coverage 85.5% 78.4% -7.2%
========================================
Files 954 798 -156
Lines 41416 35680 -5736
Branches 953 545 -408
========================================
- Hits 35439 27994 -7445
- Misses 5760 7569 +1809
+ Partials 217 117 -100
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b8f03eb
to
b78027e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
b78027e
to
9c1c816
Compare
Kudos, SonarCloud Quality Gate passed!
|
6cffab4
to
cbcc154
Compare
webserver
: fixes mypy issues in socketio
plugin
c54deec
to
a886f02
Compare
services/web/server/src/simcore_service_webserver/projects/projects_events.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/projects_events.py
Outdated
Show resolved
Hide resolved
7f4ac61
to
a17b33a
Compare
a43467c
to
48aed32
Compare
48aed32
to
9556126
Compare
Kudos, SonarCloud Quality Gate passed!
|
Code Climate has analyzed commit 9556126 and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
This PR refactors
socketio
as a pre-requisite to #2410webserver
'ssocketio
pluginmessages
api module to communicate with the front-endhandlers
Related issue/s
How to test