-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ introducing structured logging (part 2) (⚠️ devops) #4136
♻️ introducing structured logging (part 2) (⚠️ devops) #4136
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4136 +/- ##
========================================
- Coverage 88.3% 85.9% -2.4%
========================================
Files 641 796 +155
Lines 29346 35587 +6241
Branches 602 534 -68
========================================
+ Hits 25925 30591 +4666
- Misses 3284 4867 +1583
+ Partials 137 129 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…drobuliak66/osparc-simcore into maintenance/enhance-logging-part-2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. a few comments. This will help a lot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good from my side, thanks a lot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
please double check with ops the issue I raise about .env-devel
services/director-v2/src/simcore_service_director_v2/utils/logging_utils.py
Outdated
Show resolved
Hide resolved
…drobuliak66/osparc-simcore into maintenance/enhance-logging-part-2
Code Climate has analyzed commit e741070 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
Related issue/s
How to test
DevOps Checklist