-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️Maintenance: mypy simcore sdk #4138
♻️Maintenance: mypy simcore sdk #4138
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4138 +/- ##
========================================
+ Coverage 85.0% 86.4% +1.4%
========================================
Files 954 710 -244
Lines 41294 32630 -8664
Branches 946 173 -773
========================================
- Hits 35110 28202 -6908
+ Misses 5967 4380 -1587
+ Partials 217 48 -169
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
dd70f35
to
008cd3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
7976550
to
f3a8e7d
Compare
f3a8e7d
to
6e72d9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! 🎉 Greatly appreciated!
Code Climate has analyzed commit a3bd8fb and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
enable mypy in simcore-sdk
@pcrespov I need your help for this one:fixed.
Related issue/s
How to test
DevOps Checklist