Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ datcore-adapter service: New CLI with settings command (⚠️ devops) #4146

Conversation

matusdrobuliak66
Copy link
Contributor

What do these changes do?

  • ✨ Adds CLI with settings command

Related issue/s

How to test

$ cd services/catalog
$ make install-dev
$ simcore-service-catalog --help
$ make build
$ make settings-schema.json

DevOps Checklist

  • make settings-schema.json for the datcore-adapter now works

@matusdrobuliak66 matusdrobuliak66 self-assigned this Apr 22, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Jelly Beans milestone Apr 22, 2023
@matusdrobuliak66 matusdrobuliak66 added the t:maintenance Some planned maintenance work label Apr 22, 2023
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #4146 (a94d7f8) into master (7a2ba22) will decrease coverage by 22.9%.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4146      +/-   ##
=========================================
- Coverage    85.9%   63.0%   -22.9%     
=========================================
  Files         435     425      -10     
  Lines       22323   21118    -1205     
  Branches      173     173              
=========================================
- Hits        19176   13311    -5865     
- Misses       3098    7758    +4660     
  Partials       49      49              
Flag Coverage Δ
integrationtests 62.2% <ø> (+<0.1%) ⬆️
unittests 92.4% <62.5%> (+9.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...adapter/src/simcore_service_datcore_adapter/cli.py 0.0% <0.0%> (ø)
...er/src/simcore_service_datcore_adapter/__init__.py 100.0% <100.0%> (ø)
...apter/src/simcore_service_datcore_adapter/_meta.py 83.3% <100.0%> (ø)
...imcore_service_datcore_adapter/api/module_setup.py 100.0% <100.0%> (ø)
...mcore_service_datcore_adapter/api/routes/health.py 100.0% <100.0%> (ø)
...imcore_service_datcore_adapter/core/application.py 97.6% <100.0%> (ø)
...src/simcore_service_datcore_adapter/core/events.py 100.0% <100.0%> (ø)
...c/simcore_service_datcore_adapter/core/settings.py 100.0% <100.0%> (ø)

... and 271 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review April 23, 2023 17:16
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) April 24, 2023 09:53
@codeclimate
Copy link

codeclimate bot commented Apr 24, 2023

Code Climate has analyzed commit a94d7f8 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@matusdrobuliak66 matusdrobuliak66 merged commit d4bf2a0 into ITISFoundation:master Apr 24, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants