🐛 fix flaky test --> add minimum wait time that is large enough #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
reviewed
Apr 25, 2023
mrnicegyu11
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4164 +/- ##
=========================================
- Coverage 84.3% 64.5% -19.9%
=========================================
Files 957 437 -520
Lines 41452 22779 -18673
Branches 954 173 -781
=========================================
- Hits 34975 14694 -20281
- Misses 6274 8036 +1762
+ Partials 203 49 -154
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Adresses #3694 |
|
Reassigning to @pcrespov as requested. |
pcrespov
approved these changes
Apr 26, 2023
pcrespov
reviewed
Apr 26, 2023
GitHK
approved these changes
Apr 26, 2023
services/dynamic-sidecar/tests/unit/test_modules_outputs_watcher.py
Outdated
Show resolved
Hide resolved
sanderegg
approved these changes
Apr 26, 2023
…er.py Co-authored-by: Andrei Neagu <5694077+GitHK@users.noreply.github.com>
@mrnicegyu11 :-))) I meant "re-request review" :-) sorry for the confusion! |
|
Code Climate has analyzed commit c594d9c and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test would always run on my local machine, but fail sometimes on github actions. A timeout is needed here by design since a directory watcher is tested.
By decreasing the minimum timeout period successively I could make the test flaky on my local PC.
Arbitrarily we now set the minimum wait time to 3 seconds, which is 1 second more than the minimum 2sec waittime reported in failed test on github actions
Bonus:
Fixes (maybe impactful?) typo
sire_effects-->side_effects