-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Rabbitmq: use TOPIC Exchange for logs #4166
✨Rabbitmq: use TOPIC Exchange for logs #4166
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4166 +/- ##
========================================
+ Coverage 82.7% 84.6% +1.9%
========================================
Files 958 958
Lines 41560 41591 +31
Branches 955 955
========================================
+ Hits 34396 35221 +825
+ Misses 6947 6153 -794
Partials 217 217
Flags with carried forward coverage won't be shown. Click here to find out more.
|
c6c5234
to
beb9630
Compare
2785bd7
to
d31951b
Compare
4197f56
to
3bc7ae3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job!
services/web/server/src/simcore_service_webserver/notifications/_rabbitmq_consumers.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/notifications/_rabbitmq_consumers.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
c881825
to
dcf4d42
Compare
Code Climate has analyzed commit dcf4d42 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
simcore.services.logs.v2
RabbitMQ Exchange of type TOPICsimcore.services.logs
RabbitMQ Exchange of type FANOUTpublish
function and of rabbit messages (going towards not using pydantic for this)The next PR(s) will bring
Related issue/s
How to test
DevOps Checklist