Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Drop log priority #4170

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Apr 27, 2023

What do these changes do?

Making logs in director-v2 more readable. The message was wrongly logged at warning log level. Dropping to info as it makes more sense.

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK self-assigned this Apr 27, 2023
@GitHK GitHK added the a:director-v2 issue related with the director-v2 service label Apr 27, 2023
@GitHK GitHK added this to the Jelly Beans milestone Apr 27, 2023
@GitHK GitHK added the t:maintenance Some planned maintenance work label Apr 27, 2023
@GitHK GitHK marked this pull request as ready for review April 27, 2023 07:47
@codeclimate
Copy link

codeclimate bot commented Apr 27, 2023

Code Climate has analyzed commit 5d8da2a and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@GitHK GitHK enabled auto-merge (squash) April 27, 2023 07:51
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #4170 (5d8da2a) into master (beb9630) will decrease coverage by 11.6%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4170      +/-   ##
=========================================
- Coverage    84.3%   72.8%   -11.6%     
=========================================
  Files         955     377     -578     
  Lines       41398   19401   -21997     
  Branches      952       0     -952     
=========================================
- Hits        34937   14124   -20813     
+ Misses       6245    5277     -968     
+ Partials      216       0     -216     
Flag Coverage Δ
integrationtests 66.7% <100.0%> (+13.7%) ⬆️
unittests 86.3% <100.0%> (+4.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tor_v2/modules/dynamic_sidecar/docker_api/_core.py 96.0% <100.0%> (ø)

... and 744 files with indirect coverage changes

@GitHK GitHK merged commit f1fefe2 into ITISFoundation:master Apr 27, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants