Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Autoscaling: fix out of sequence error #4181

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Apr 28, 2023

What do these changes do?

Shall massively reduce the occurrence of the out of sequence error in the autoscaling logs. Which is nonetheless not a problem. mostly cosmetics as the draining is repeated in the next iteration.

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the a:autoscaling autoscaling service in simcore's stack label Apr 28, 2023
@sanderegg sanderegg added this to the The Next Milestone milestone Apr 28, 2023
@sanderegg sanderegg self-assigned this Apr 28, 2023
@sanderegg sanderegg requested a review from pcrespov as a code owner April 28, 2023 16:43
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #4181 (d302347) into master (320f091) will decrease coverage by 17.7%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4181      +/-   ##
=========================================
- Coverage    84.3%   66.7%   -17.7%     
=========================================
  Files         957     420     -537     
  Lines       41451   21593   -19858     
  Branches      954     173     -781     
=========================================
- Hits        34962   14403   -20559     
- Misses       6286    7141     +855     
+ Partials      203      49     -154     
Flag Coverage Δ
integrationtests 65.2% <ø> (+3.8%) ⬆️
unittests 98.0% <100.0%> (+15.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../simcore_service_autoscaling/utils/utils_docker.py 100.0% <100.0%> (ø)

... and 788 files with indirect coverage changes

@sanderegg sanderegg force-pushed the bugfix/out_of_sequence_error branch from aec0b7a to d7fee9b Compare April 28, 2023 20:41
@sanderegg sanderegg force-pushed the bugfix/out_of_sequence_error branch from d7fee9b to d302347 Compare May 2, 2023 09:15
@codeclimate
Copy link

codeclimate bot commented May 2, 2023

Code Climate has analyzed commit d302347 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg merged commit 3ef7249 into ITISFoundation:master May 2, 2023
@sanderegg sanderegg deleted the bugfix/out_of_sequence_error branch May 2, 2023 11:22
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:autoscaling autoscaling service in simcore's stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoscaling update ot of sequence error in docker
4 participants