-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixes broken migrated_pg_tables_context #4182
🐛 Fixes broken migrated_pg_tables_context #4182
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4182 +/- ##
========================================
+ Coverage 83.9% 84.2% +0.2%
========================================
Files 946 957 +11
Lines 40741 41452 +711
Branches 954 954
========================================
+ Hits 34213 34912 +699
+ Misses 6325 6324 -1
- Partials 203 216 +13
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good thanks.
I guess this should be moved to where the migration service is restarted ideally.
Code Climate has analyzed commit 04ad0f5 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
Since the
migration
is updated (containers restart). We need to consider the current running task in order to properly assert that the migration passed.Related issue/s
How to test
DevOps Checklist