Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes broken migrated_pg_tables_context #4182

Merged
merged 3 commits into from
May 2, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented May 2, 2023

What do these changes do?

Since the migration is updated (containers restart). We need to consider the current running task in order to properly assert that the migration passed.

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK self-assigned this May 2, 2023
@GitHK GitHK added changelog:🐛bugfix t:maintenance Some planned maintenance work labels May 2, 2023
@GitHK GitHK added this to the The Next Milestone milestone May 2, 2023
@GitHK GitHK marked this pull request as ready for review May 2, 2023 11:46
@GitHK GitHK requested review from pcrespov and sanderegg as code owners May 2, 2023 11:46
@GitHK GitHK changed the title 🐛 Fixes broken test 🐛 Fixes broken migration fixture May 2, 2023
@GitHK GitHK changed the title 🐛 Fixes broken migration fixture 🐛 Fixes broken migrated_pg_tables_context May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #4182 (04ad0f5) into master (ee12786) will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4182     +/-   ##
========================================
+ Coverage    83.9%   84.2%   +0.2%     
========================================
  Files         946     957     +11     
  Lines       40741   41452    +711     
  Branches      954     954             
========================================
+ Hits        34213   34912    +699     
+ Misses       6325    6324      -1     
- Partials      203     216     +13     
Flag Coverage Δ
integrationtests 63.8% <ø> (+4.0%) ⬆️
unittests 82.4% <ø> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 47 files with indirect coverage changes

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good thanks.
I guess this should be moved to where the migration service is restarted ideally.

@GitHK GitHK requested a review from matusdrobuliak66 May 2, 2023 12:20
@GitHK GitHK enabled auto-merge (squash) May 2, 2023 12:22
@codeclimate
Copy link

codeclimate bot commented May 2, 2023

Code Climate has analyzed commit 04ad0f5 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@GitHK GitHK merged commit d59ba4d into ITISFoundation:master May 2, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants