Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ webserver: fixes mypy issues in email plugin #4198

Conversation

matusdrobuliak66
Copy link
Contributor

What do these changes do?

  • ♻️ refactors email plugin in webserver:

Related issue/s

How to test

cd services/web/server
make mypy | grep email

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this May 7, 2023
@matusdrobuliak66 matusdrobuliak66 added the t:maintenance Some planned maintenance work label May 7, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Pastel de Nata milestone May 7, 2023
@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Merging #4198 (3716b36) into master (109de05) will decrease coverage by 2.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4198      +/-   ##
=========================================
- Coverage    85.5%   83.4%    -2.1%     
=========================================
  Files         961     381     -580     
  Lines       41640   19555   -22085     
  Branches      955       0     -955     
=========================================
- Hits        35622   16321   -19301     
+ Misses       5801    3234    -2567     
+ Partials      217       0     -217     
Flag Coverage Δ
integrationtests 66.7% <100.0%> (-0.7%) ⬇️
unittests 83.9% <100.0%> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erver/src/simcore_service_webserver/application.py 97.8% <100.0%> (ø)
...erver/src/simcore_service_webserver/email/_core.py 82.3% <100.0%> (ø)
...r/src/simcore_service_webserver/email/_handlers.py 91.6% <100.0%> (ø)
...rver/src/simcore_service_webserver/email/plugin.py 93.7% <100.0%> (ø)
...er/src/simcore_service_webserver/email/settings.py 100.0% <100.0%> (ø)
...erver/src/simcore_service_webserver/email/utils.py 100.0% <100.0%> (ø)
...rver/src/simcore_service_webserver/login/plugin.py 90.0% <100.0%> (ø)
...src/simcore_service_webserver/login/utils_email.py 87.5% <100.0%> (ø)
...rver/src/simcore_service_webserver/publications.py 100.0% <100.0%> (ø)

... and 660 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review May 8, 2023 06:02
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) May 8, 2023 13:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented May 9, 2023

Code Climate has analyzed commit 3716b36 and detected 0 issues on this pull request.

View more on Code Climate.

@matusdrobuliak66 matusdrobuliak66 merged commit f6c6d69 into ITISFoundation:master May 9, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants