Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Project list items include permalink #4214

Merged
merged 12 commits into from
May 11, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented May 10, 2023

What do these changes do?

Projects in list did not include permalink field. This PR

  • 🐛 Adds missing permalink field in ProjectListItem model used in the response to list_projects
  • ♻️ Moves implementations of list, get to _read_utils
  • 🐛 minor fixes in front-end by @odeimaiz

Related issue/s

@pcrespov pcrespov self-assigned this May 10, 2023
@pcrespov pcrespov added this to the Pastel de Nata milestone May 10, 2023
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #4214 (3b29fa2) into master (5b4b9b3) will increase coverage by 2.7%.
The diff coverage is 96.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4214      +/-   ##
=========================================
+ Coverage    84.5%   87.3%    +2.7%     
=========================================
  Files         952     365     -587     
  Lines       41355   18932   -22423     
  Branches      953       0     -953     
=========================================
- Hits        34958   16530   -18428     
+ Misses       6180    2402    -3778     
+ Partials      217       0     -217     
Flag Coverage Δ
integrationtests 60.5% <96.5%> (-1.4%) ⬇️
unittests 84.5% <96.5%> (+2.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../simcore_service_webserver/projects/_read_utils.py 96.2% <96.2%> (ø)
...rvice_webserver/projects/projects_handlers_crud.py 87.5% <100.0%> (-0.5%) ⬇️

... and 590 files with indirect coverage changes

@pcrespov pcrespov force-pushed the fix/list-prj-permalink branch from d14617a to b181813 Compare May 10, 2023 14:38
@pcrespov pcrespov marked this pull request as ready for review May 10, 2023 15:00
@pcrespov pcrespov added bug buggy, it does not work as expected a:webserver issue related to the webserver service and removed changelog:🐛bugfix labels May 10, 2023
@pcrespov pcrespov enabled auto-merge (squash) May 10, 2023 15:02
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pair tested

@pcrespov pcrespov force-pushed the fix/list-prj-permalink branch from 2f44a62 to b48381b Compare May 11, 2023 07:32
@codeclimate
Copy link

codeclimate bot commented May 11, 2023

Code Climate has analyzed commit 3b29fa2 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit d9fd2da into ITISFoundation:master May 11, 2023
@pcrespov pcrespov deleted the fix/list-prj-permalink branch May 11, 2023 13:00
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants