-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Project list items include permalink #4214
🐛 Project list items include permalink #4214
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4214 +/- ##
=========================================
+ Coverage 84.5% 87.3% +2.7%
=========================================
Files 952 365 -587
Lines 41355 18932 -22423
Branches 953 0 -953
=========================================
- Hits 34958 16530 -18428
+ Misses 6180 2402 -3778
+ Partials 217 0 -217
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d14617a
to
b181813
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pair tested
services/web/server/tests/unit/with_dbs/02/test_projects_handlers_crud.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_read_utils.py
Outdated
Show resolved
Hide resolved
2f44a62
to
b48381b
Compare
Code Climate has analyzed commit 3b29fa2 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
Projects in list did not include
permalink
field. This PRpermalink
field inProjectListItem
model used in the response tolist_projects
_read_utils
Related issue/s