🎨 Study dispatcher messages improvements

[elisabettai]

What do these changes do?

When a non-logged in user try to access a template shared with everyone (but requiring log in) will now see a clearer and shorter message.
The login button has been made more prominent by giving it the "strong color" and by moving it to the first position (left-most button).

Related issue/s

• fixes Improve error message when trying to open a non published template as anonymous user osparc-issues#945

How to test

In a local deploy, publish a template and share it with Everyone, then try to access it without being logged in.
Note: in the .env file, WEBSERVER_STUDIES_ACCESS_ENABLED needs to be 1

Notes

Also small frontend change at @odeimaiz.

DevOps Checklist

[codecov]

Codecov Report

Merging #4229 (6de66c4) into master (57bba7e) will decrease coverage by 4.1%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           master   #4229      +/-   ##
=========================================
- Coverage    83.8%   79.8%    -4.1%     
=========================================
  Files         976     399     -577     
  Lines       41981   20700   -21281     
  Branches      965     173     -792     
=========================================
- Hits        35221   16524   -18697     
+ Misses       6539    4127    -2412     
+ Partials      221      49     -172     

Flag	Coverage Δ
integrationtests	63.7% <36.3%> (-5.2%)	⬇️
unittests	84.4% <100.0%> (+2.3%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...erver/src/simcore_service_webserver/projects/db.py	96.6% <ø> (+0.3%)	⬆️
...service_webserver/studies_dispatcher/_constants.py	100.0% <ø> (ø)
...rc/simcore_service_webserver/projects/_db_utils.py	97.0% <100.0%> (+<0.1%)	⬆️
...ce_webserver/studies_dispatcher/_studies_access.py	91.1% <100.0%> (+0.4%)	⬆️

... and 634 files with indirect coverage changes

[pcrespov]

I can give you more details tomorrow :-)

[elisabettai]

@pcrespov, the tests of the study_dispatcher need to be updated, it is clear to me why the CI is failing, see here.

For test_access_to_forbidden_study it makes sense that to change the test, since now we expect a different error code, but I'm not sure this change is good for test_access_to_invalid_study.

[pcrespov]

test_access_to_invalid_study

@elisabettai Let's check that tomorrow together

[odeimaiz]

JS part lgtm

[GitHK]

Nice

[codeclimate]

Code Climate has analyzed commit 6de66c4 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication