-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Refactor exporter functionality Part1/2 (⚠️ devops) #4258
♻️ Refactor exporter functionality Part1/2 (⚠️ devops) #4258
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4258 +/- ##
=========================================
+ Coverage 74.9% 84.6% +9.7%
=========================================
Files 789 389 -400
Lines 31968 20234 -11734
Branches 966 173 -793
=========================================
- Hits 23956 17127 -6829
+ Misses 7804 3058 -4746
+ Partials 208 49 -159
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…xporter-refactor-1
…xporter-refactor-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of changes :-)
Add some hints and comments.
I will approve to avoid blocking it too long .
pls follow up on the comments
thx!
services/web/server/src/simcore_service_webserver/exporter/settings.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/exporter/request_handlers.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/exporter/formatter/archive.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/integration/01/test_exporter_requests_handlers.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/integration/01/test_exporter_requests_handlers.py
Show resolved
Hide resolved
services/web/server/tests/unit/isolated/test_exporter_formatter_archive.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to delete all that stuff..
services/web/server/src/simcore_service_webserver/exporter/formatter/xlsx/utils.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/integration/01/test_exporter_requests_handlers.py
Show resolved
Hide resolved
…xporter-refactor-1
Code Climate has analyzed commit b6850fd and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
No intervention from devops should be required
NOTE: the
WEBSERVER_EXPORTER
is set asnull
(disabled) on all deployments. The only env var that I have added isEXPORTER_ENABLED
which defaults toFalse
. This should not be a problem.Removed env vars:
EXPORTER_MAX_UPLOAD_FILE_SIZE
no longer usedEXPORTER_DOWNLOADER_MAX_TIMEOUT_SECONDS
no longer usedAdded env vars:
WEBSERVER_EXPORTER
default toFalse
What do these changes do?
This is a two part series where the webserver's
exporter
module into will become thesds
module. Note:SDS = SPARC Dataset Standard
Changes:
NOTE: renaming of the module of and of the env vars, together with the mypy fixes, will come with the second part
Related issue/s
How to test
DevOps Checklist