Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Fix max iter #4272

Merged
merged 3 commits into from
Jun 1, 2023
Merged

♻️ Fix max iter #4272

merged 3 commits into from
Jun 1, 2023

Conversation

bisgaard-itis
Copy link
Contributor

Fix optimization example

What do these changes do?

Fix the maximum number of iterations in the example.

Related issue/s

How to test

DevOps Checklist

@bisgaard-itis bisgaard-itis requested a review from pcrespov as a code owner May 25, 2023 10:32
@bisgaard-itis bisgaard-itis self-assigned this May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #4272 (ace8469) into master (e804317) will decrease coverage by 1.2%.
The diff coverage is n/a.

❗ Current head ace8469 differs from pull request most recent head 9f4ec97. Consider uploading reports for the commit 9f4ec97 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4272     +/-   ##
========================================
- Coverage    86.2%   85.0%   -1.2%     
========================================
  Files         804     976    +172     
  Lines       37613   41989   +4376     
  Branches      880     965     +85     
========================================
+ Hits        32425   35713   +3288     
- Misses       4984    6055   +1071     
- Partials      204     221     +17     
Flag Coverage Δ
integrationtests 63.7% <ø> (-4.1%) ⬇️
unittests 82.6% <ø> (-1.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 243 files with indirect coverage changes

Copy link
Contributor

@colinRawlings colinRawlings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Mads

@pcrespov pcrespov added this to the Pastel de Nata milestone May 30, 2023
@pcrespov pcrespov enabled auto-merge (squash) May 30, 2023 16:23
@codeclimate
Copy link

codeclimate bot commented Jun 1, 2023

Code Climate has analyzed commit 9f4ec97 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pcrespov pcrespov disabled auto-merge June 1, 2023 09:42
@pcrespov pcrespov merged commit 2835ea6 into master Jun 1, 2023
@pcrespov pcrespov deleted the 767-optimization-example-fix-max-iter branch June 1, 2023 09:43
@matusdrobuliak66 matusdrobuliak66 changed the title Fix max iter ♻️ Fix max iter Jun 6, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 14, 2023
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants