🎨 e2e: move widget id from nodeTreeItem to nodeTreeItem's label #4281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
requested review from
colinRawlings,
GitHK,
mrnicegyu11,
elisabettai,
mguidon and
sanderegg
odeimaiz
changed the title
odeimaiz
changed the title
services/static-webserver/client/source/class/osparc/component/widget/NodeTreeItem.js
Show resolved
Hide resolved
|
Code Climate has analyzed commit b44bca3 and detected 0 issues on this pull request. View more on Code Climate. |
GitHK
approved these changes
May 30, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
During the e2e testing it can happen that when puppeteer clicks on the node tree item on the primary column, the fullscreen button gets clicked, bringing an unexpected scenario. This happens when the fullscreen button gets rendered right in the middle of the widget.
This PR moves the id given to the widget (the one puppeteer looks for) from the entry in the tree to the label in the entry in the tree.
Related issue/s
How to test
DevOps Checklist