Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ revert rabbit mq named data volume creation in simcore repo #4296

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Jun 1, 2023

What do these changes do?

Revert changes from osparc-simcore repository:

that were introduced in the osparc-ops-environment repository here:

Note: we introduce them in the osparc-ops-environments as we were doing the release so we wanted changes in the production as soon as possible as they fix this issue #4279

Related issue/s

How to test

DevOps Checklist

@codeclimate
Copy link

codeclimate bot commented Jun 1, 2023

Code Climate has analyzed commit b6fbda5 and detected 0 issues on this pull request.

View more on Code Climate.

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review June 1, 2023 17:57
@matusdrobuliak66 matusdrobuliak66 self-assigned this Jun 1, 2023
@matusdrobuliak66 matusdrobuliak66 added the t:maintenance Some planned maintenance work label Jun 1, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Pastel de Nata milestone Jun 1, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #4296 (b6fbda5) into master (a25c044) will increase coverage by 4.5%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4296     +/-   ##
========================================
+ Coverage    72.6%   77.1%   +4.5%     
========================================
  Files         781     815     +34     
  Lines       33173   37680   +4507     
  Branches      600     890    +290     
========================================
+ Hits        24087   29076   +4989     
+ Misses       8948    8398    -550     
- Partials      138     206     +68     
Flag Coverage Δ
integrationtests 67.8% <ø> (ø)
unittests 74.2% <ø> (-3.0%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 409 files with indirect coverage changes

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was just wondering one thing. are you using the same naming conventions in osparc-ops-environment?
because if yes maybe you can keep them like this.

@matusdrobuliak66
Copy link
Contributor Author

was just wondering one thing. are you using the same naming conventions in osparc-ops-environment? because if yes maybe you can keep them like this.

yes we are using the same naming convention, so I will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants