Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️Computational services: pass as logs even if recognized as a progress value #4381

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jun 19, 2023

What do these changes do?

This is an attempt at fixing the issue in the e2e with isolve-mpi missing logs.

  • pass the logs to the frontend even if it is recognized as progress value.

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the a:dask-service Any of the dask services: dask-scheduler/sidecar or worker label Jun 19, 2023
@sanderegg sanderegg added this to the Watermelon milestone Jun 19, 2023
@sanderegg sanderegg self-assigned this Jun 19, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 19, 2023

Code Climate has analyzed commit a698e83 and detected 0 issues on this pull request.

View more on Code Climate.

@sanderegg sanderegg requested review from pcrespov and mguidon and removed request for pcrespov June 19, 2023 08:01
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool stuff

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #4381 (a698e83) into master (c8dee4b) will increase coverage by 7.4%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4381      +/-   ##
=========================================
+ Coverage    86.0%   93.4%    +7.4%     
=========================================
  Files         943      13     -930     
  Lines       41275     698   -40577     
  Branches     1006       0    -1006     
=========================================
- Hits        35500     652   -34848     
+ Misses       5544      46    -5498     
+ Partials      231       0     -231     
Flag Coverage Δ
integrationtests ?
unittests 93.4% <100.0%> (+9.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dask_sidecar/computational_sidecar/docker_utils.py 92.7% <100.0%> (ø)

... and 930 files with indirect coverage changes

Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go

@sanderegg sanderegg merged commit ddb37c4 into ITISFoundation:master Jun 19, 2023
@sanderegg sanderegg deleted the maintenance/pass-logs-also-when-only-progress branch June 19, 2023 08:09
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm... does not look to be related, but let's see if it helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dask-service Any of the dask services: dask-scheduler/sidecar or worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants