♻️ extending run_id with int_timestamp

[GitHK]

What do these changes do?

The run_id used for running dynamic services is not very useful since it does not encode any information that can be of help.

Changing it to also include int_timestamp string everywhere. This will allow us to more accurately track sort the data associated with each run. This is especially important since our file backup systems keep the original created and last change dates. So you cannot tell by looking at the parent folder which is the latest one. The time information regarding the creation of the volume needs to be tracked in the name.

NOTE: after changing the type from UUID to str, the changes are still retrocompatible with the old legacy data format for the state of the dynamic sidecar, in fact that one was not changed

Related issue/s

• improving dynamic-sidecar design osparc-issues#638
• fixes Improve the run_id on the dy-sidecar osparc-issues#1015

How to test

DevOps Checklist

[codecov]

Codecov Report

Merging #4505 (da4bec8) into master (bd7f4b4) will increase coverage by 3.3%.
The diff coverage is 75.0%.

@@           Coverage Diff            @@
##           master   #4505     +/-   ##
========================================
+ Coverage    83.8%   87.1%   +3.3%     
========================================
  Files        1009     844    -165     
  Lines       43193   38670   -4523     
  Branches      997     482    -515     
========================================
- Hits        36197   33719   -2478     
+ Misses       6767    4837   -1930     
+ Partials      229     114    -115     

Flag	Coverage Δ
integrationtests	68.3% <100.0%> (+<0.1%)	⬆️
unittests	84.4% <66.6%> (+3.3%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...es/dynamic_sidecar/docker_service_specs/sidecar.py	87.7% <ø> (ø)
...src/simcore_service_dynamic_sidecar/core/errors.py	100.0% <ø> (ø)
...ages/models-library/src/models_library/services.py	92.5% <66.6%> (-1.7%)	⬇️
...or_v2/models/schemas/dynamic_services/scheduler.py	98.7% <100.0%> (ø)
...modules/dynamic_sidecar/scheduler/_core/_events.py	96.7% <100.0%> (-0.1%)	⬇️

... and 229 files with indirect coverage changes

[matusdrobuliak66]

👍

[sanderegg]

Along the same lines as @matusdrobuliak66 said I am a bit concerned about the uniqueness of this run_id and would like to understand better where and how it is used. Please consider a scenario with multiple director-v2s

[sanderegg]

Are you ensuring backwards compatibility still?

[codeclimate]

Code Climate has analyzed commit da4bec8 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.1% Duplication