-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ upgrading docker-compose to 2.x.x in dynamic-sidecar 🚨 #4545
⬆️ upgrading docker-compose to 2.x.x in dynamic-sidecar 🚨 #4545
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4545 +/- ##
=========================================
+ Coverage 85.7% 89.9% +4.2%
=========================================
Files 1009 60 -949
Lines 43186 3183 -40003
Branches 997 0 -997
=========================================
- Hits 37015 2862 -34153
+ Misses 5942 321 -5621
+ Partials 229 0 -229
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 please also add 🚨 to the name of the PR, so we know we should be careful. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! thx
If possible after this PR, could you please fully upgrade the service requirements in a separate PR . Yesterday I did not dare upgrading e.g. aiohttp
to avoid creating confilcts with this PR. thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! please also check if cython really needs to be installed with @pcrespov. I think there is no need to install unneeded packages.
Code Climate has analyzed commit f61f71f and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
docker-compose
was replaced withdocker compose
inside thedynamic-sidecar
compose-spec
upgraded network format which was deprecated.external
is no longer a dic.docker-compose
python package is no longer a dependency of thedynamic-sidecar
, it is now installed via apt.dynamic-sidecar
's dependencies.Bonus:
docker-ce-cli
anddocker-compose-plugin
versions in the docker images of theautoscaling
anddynamic-sidecar
services.PyYAML==6.0.1
in thedynamic-sidecar
Checks:
master
tostaging
make sure to also include this pr 🐛 fixes broken image build in master #4547 @matusdrobuliak66Related issue/s
How to test
DevOps Checklist