Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ upgrade dynamic-sidecar service requirements #4551

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jul 27, 2023

What do these changes do?

Upgraded service requirements for dynamic-sidecar. An update was overdue.

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK self-assigned this Jul 27, 2023
@GitHK GitHK added t:maintenance Some planned maintenance work a:dynamic-sidecar dynamic-sidecar service changelog:♻️refactor labels Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #4551 (a54be22) into master (9b305ff) will decrease coverage by 12.7%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4551      +/-   ##
=========================================
- Coverage    86.4%   73.8%   -12.7%     
=========================================
  Files        1009     441     -568     
  Lines       43204   23161   -20043     
  Branches      997     186     -811     
=========================================
- Hits        37353   17093   -20260     
- Misses       5622    6015     +393     
+ Partials      229      53     -176     
Flag Coverage Δ
integrationtests 68.3% <ø> (+1.5%) ⬆️
unittests 85.6% <ø> (+1.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...core_service_director_v2/utils/osparc_variables.py 95.4% <ø> (ø)

... and 748 files with indirect coverage changes

@GitHK GitHK marked this pull request as ready for review July 27, 2023 06:26
@GitHK GitHK requested review from sanderegg and pcrespov as code owners July 27, 2023 06:41
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! 🎉

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@GitHK GitHK enabled auto-merge (squash) July 27, 2023 08:57
@GitHK GitHK requested a review from matusdrobuliak66 July 27, 2023 08:57
@codeclimate
Copy link

codeclimate bot commented Jul 27, 2023

Code Climate has analyzed commit a54be22 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@GitHK GitHK merged commit 162115e into ITISFoundation:master Jul 27, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dynamic-sidecar dynamic-sidecar service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants