Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Is922/add rabbitMQ to resource usage tracker #4583

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Aug 7, 2023

What do these changes do?

  • ✨ add rabbitMQ to the resource usage tracker
  • ♻️ put the previously intended logic of scraping Prometheus to separate module "Prometheus containers" for now. And comment it out in the application core.

In upcoming PRs, we will create/connect to the rabbitMQ queue:
image

Related issue/s

How to test

cd services/resource-usage-tracker
make install-dev
make test-dev

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 changed the title WIP: Is922/resource usage tracker rabbitmq ✨ Is922/add rabbitMQ to resource usage tracker Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #4583 (920ff16) into master (be68c25) will decrease coverage by 0.4%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4583     +/-   ##
========================================
- Coverage    86.7%   86.4%   -0.4%     
========================================
  Files        1023     731    -292     
  Lines       43822   34506   -9316     
  Branches     1013     850    -163     
========================================
- Hits        38023   29822   -8201     
+ Misses       5572    4493   -1079     
+ Partials      227     191     -36     
Flag Coverage Δ
integrationtests 66.7% <ø> (+0.1%) ⬆️
unittests 86.4% <100.0%> (+2.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ls-library/src/models_library/rabbitmq_messages.py 90.9% <100.0%> (ø)
...ackages/service-library/src/servicelib/rabbitmq.py 94.1% <100.0%> (+<0.1%) ⬆️

... and 334 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review August 7, 2023 08:01
@matusdrobuliak66 matusdrobuliak66 self-assigned this Aug 7, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Sundae milestone Aug 7, 2023
@matusdrobuliak66 matusdrobuliak66 added the a:resource-usage-tracker resource usage tracker service label Aug 7, 2023
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
2 things:

  • you can already connect to the rabbitmq exchanges and test it
  • please do not keep dead code if you plan on totally removing it or not using it in the near future.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, plus please check the 3 code smells from sonar cloud.

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) August 8, 2023 12:21
@codeclimate
Copy link

codeclimate bot commented Aug 9, 2023

Code Climate has analyzed commit 920ff16 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg merged commit 330fa2f into ITISFoundation:master Aug 9, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:resource-usage-tracker resource usage tracker service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants