-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Is922/add rabbitMQ to resource usage tracker #4583
✨ Is922/add rabbitMQ to resource usage tracker #4583
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4583 +/- ##
========================================
- Coverage 86.7% 86.4% -0.4%
========================================
Files 1023 731 -292
Lines 43822 34506 -9316
Branches 1013 850 -163
========================================
- Hits 38023 29822 -8201
+ Misses 5572 4493 -1079
+ Partials 227 191 -36
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
2 things:
- you can already connect to the rabbitmq exchanges and test it
- please do not keep dead code if you plan on totally removing it or not using it in the near future.
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/modules/rabbitmq.py
Outdated
Show resolved
Hide resolved
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/cli.py
Outdated
Show resolved
Hide resolved
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/resource_tracker.py
Outdated
Show resolved
Hide resolved
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/resource_tracker.py
Outdated
Show resolved
Hide resolved
...ces/resource-usage-tracker/tests/unit/modules/prometheus_containers/test_resource_tracker.py
Show resolved
Hide resolved
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/modules/rabbitmq.py
Outdated
Show resolved
Hide resolved
...ces/resource-usage-tracker/tests/unit/modules/prometheus_containers/test_resource_tracker.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me, plus please check the 3 code smells from sonar cloud.
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/core/application.py
Outdated
Show resolved
Hide resolved
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/resource_tracker.py
Outdated
Show resolved
Hide resolved
Code Climate has analyzed commit 920ff16 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
In upcoming PRs, we will create/connect to the rabbitMQ queue:

Related issue/s
How to test
DevOps Checklist