Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix openapi swagger page dispay (missing env-var capture) #4584

Conversation

mrnicegyu11
Copy link
Member

The capture of the the env-var REST_SWAGGER_API_DOC_ENABLED went missing, which causes the swagger-openapi documents to not display anymore (404 on https://s4l-master.speag.com/dev/doc etc.).

This addresses it.

@mrnicegyu11 mrnicegyu11 added bug buggy, it does not work as expected a:webserver issue related to the webserver service changelog:🐛bugfix labels Aug 7, 2023
@mrnicegyu11 mrnicegyu11 added this to the Sundae milestone Aug 7, 2023
@mrnicegyu11 mrnicegyu11 self-assigned this Aug 7, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 7, 2023

Code Climate has analyzed commit e797535 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mrnicegyu11 mrnicegyu11 enabled auto-merge (squash) August 7, 2023 08:50
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #4584 (e797535) into master (2b25897) will decrease coverage by 6.9%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4584      +/-   ##
=========================================
- Coverage    86.7%   79.9%    -6.9%     
=========================================
  Files        1023     525     -498     
  Lines       43763   26144   -17619     
  Branches     1014     534     -480     
=========================================
- Hits        37958   20894   -17064     
+ Misses       5578    5126     -452     
+ Partials      227     124     -103     
Flag Coverage Δ
integrationtests 65.2% <ø> (-1.5%) ⬇️
unittests 79.9% <ø> (-4.4%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 626 files with indirect coverage changes

@mrnicegyu11 mrnicegyu11 merged commit 169e0e7 into ITISFoundation:master Aug 7, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants