Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 bugfix on wallet update #4589

Merged
merged 3 commits into from
Aug 8, 2023
Merged

🐛 bugfix on wallet update #4589

merged 3 commits into from
Aug 8, 2023

Conversation

matusdrobuliak66
Copy link
Contributor

What do these changes do?

  • 🐛 bugfix on wallet update endpoint

Related issue/s

How to test

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 added this to the Sundae milestone Aug 8, 2023
@matusdrobuliak66 matusdrobuliak66 self-assigned this Aug 8, 2023
@matusdrobuliak66 matusdrobuliak66 added the a:webserver issue related to the webserver service label Aug 8, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review August 8, 2023 13:58
odeimaiz
odeimaiz approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Aug 8, 2023 •
edited
Loading

Codecov Report

Merging #4589 (3740bd1) into master (0f9d22d) will decrease coverage by 4.5%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4589     +/-   ##
========================================
- Coverage    86.4%   81.9%   -4.5%     
========================================
  Files         660     447    -213     
  Lines       30535   23454   -7081     
  Branches      650     188    -462     
========================================
- Hits        26396   19223   -7173     
- Misses       3990    4184    +194     
+ Partials      149      47    -102
Flag Coverage Δ
integrationtests 66.7% <100.0%> (-0.1%) ⬇️
unittests 86.9% <100.0%> (+1.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rver/src/simcore_service_webserver/wallets/_api.py 84.6% <ø> (ø)
...erver/src/simcore_service_webserver/wallets/_db.py 81.1% <ø> (ø)
...src/simcore_service_webserver/wallets/_handlers.py 98.6% <100.0%> (ø)

... and 286 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) August 8, 2023 14:18
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Aug 8, 2023

Code Climate has analyzed commit 3740bd1 and detected 0 issues on this pull request.

View more on Code Climate.

@matusdrobuliak66 matusdrobuliak66 merged commit af9082e into ITISFoundation:master Aug 8, 2023
@odeimaiz odeimaiz mentioned this pull request Aug 8, 2023
Merged
1 task
@sanderegg sanderegg mentioned this pull request Aug 15, 2023
Closed
16 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
Closed
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odeimaiz odeimaiz odeimaiz approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

@GitHK GitHK Awaiting requested review from GitHK GitHK is a code owner

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels
a:webserver issue related to the webserver service
Projects
None yet
Milestone
Sundae
Development

Successfully merging this pull request may close these issues.
4 participants
@matusdrobuliak66 @GitHK @odeimaiz @sanderegg