♻️Rabbitmq rpc: response shall not be jsonized #4730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
a:services-library
pcrespov
approved these changes
Sep 11, 2023
| result = await func(*args, **kwargs) | ||
| return result | ||
| except asyncio.CancelledError: | ||
| _logger.debug("call was cancelled") |
Codecov Report
@@ Coverage Diff @@
## master #4730 +/- ##
=========================================
+ Coverage 66.2% 85.9% +19.7%
=========================================
Files 739 894 +155
Lines 33298 39110 +5812
Branches 198 543 +345
=========================================
+ Hits 22059 33620 +11561
+ Misses 11191 5366 -5825
- Partials 48 124 +76
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
🎉 will start using this in my new PR! thx! |
sanderegg
force-pushed
the
rabbitmq-rpc/no-json
branch
from
f49d6f5 to
de200cc
Compare
|
Code Climate has analyzed commit de200cc and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The concept is to have a common/shared interface module that defines the types of whatever is returned through RPC
Related issue/s
pre-requisite of #4703
How to test
DevOps Checklist